-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
40329: storage: return LeaseRejectedError when learner requests lease r=danhhz a=tbg We would previously return an unstructured error which would leak to the client. The LeaseRejectedError gets turned into a NotLeaseholderError instead, and DistSender will try another replica. Fixes #40323. Note that DistSender doesn't send to learners in the first place, so it's unclear why we asked a learner to request a lease, but it's likely that we upgraded the learner to a voter while it was down (the test below restarts nodes) and it received a request while it was already a voter but not aware of it. Release note: None Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
- Loading branch information
Showing
4 changed files
with
25 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters