diff --git a/DEPS.bzl b/DEPS.bzl index e05062117da8..9b9e0ba00c04 100644 --- a/DEPS.bzl +++ b/DEPS.bzl @@ -2,7 +2,7 @@ load("@bazel_gazelle//:deps.bzl", "go_repository") # PRO-TIP: You can inject temorary changes to any of these dependencies by # by pointing to an alternate remote to clone from. Delete the `sha256`, -# `strip_prefix`, and ` + `urls` parameters, and add `vcs = "git"` as well as a +# `strip_prefix`, and `urls` parameters, and add `vcs = "git"` as well as a # custom `remote` and `commit`. For example: # go_repository( # name = "com_github_cockroachdb_sentry_go", diff --git a/pkg/cmd/mirror/mirror.go b/pkg/cmd/mirror/mirror.go index 4320e97db89f..3bff4fdf5551 100644 --- a/pkg/cmd/mirror/mirror.go +++ b/pkg/cmd/mirror/mirror.go @@ -337,7 +337,7 @@ func dumpNewDepsBzl( # PRO-TIP: You can inject temorary changes to any of these dependencies by # by pointing to an alternate remote to clone from. Delete the ` + "`sha256`" + `, -# ` + "`strip_prefix`, and ` + `urls`" + ` parameters, and add ` + "`vcs = \"git\"`" + ` as well as a +# ` + "`strip_prefix`, and `urls` parameters, and add `vcs = \"git\"`" + ` as well as a # custom ` + "`remote` and `commit`" + `. For example: # go_repository( # name = "com_github_cockroachdb_sentry_go", diff --git a/pkg/cmd/roachtest/tests/cdc.go b/pkg/cmd/roachtest/tests/cdc.go index 0ee575dac861..31053ed85dda 100644 --- a/pkg/cmd/roachtest/tests/cdc.go +++ b/pkg/cmd/roachtest/tests/cdc.go @@ -547,7 +547,11 @@ func runCDCBank(ctx context.Context, t test.Test, c cluster.Cluster) { crdbNodes, workloadNode, kafkaNode := c.Range(1, c.Spec().NodeCount-1), c.Node(c.Spec().NodeCount), c.Node(c.Spec().NodeCount) c.Put(ctx, t.Cockroach(), "./cockroach", crdbNodes) c.Put(ctx, t.DeprecatedWorkload(), "./workload", workloadNode) - c.Start(ctx, t.L(), option.DefaultStartOpts(), install.MakeClusterSettings(), crdbNodes) + startOpts := option.DefaultStartOpts() + startOpts.RoachprodOpts.ExtraArgs = append(startOpts.RoachprodOpts.ExtraArgs, + "--vmodule=changefeed=2", + ) + c.Start(ctx, t.L(), startOpts, install.MakeClusterSettings(), crdbNodes) kafka, cleanup := setupKafka(ctx, t, c, kafkaNode) defer cleanup() diff --git a/pkg/sql/logictest/testdata/logic_test/upsert b/pkg/sql/logictest/testdata/logic_test/upsert index f52f5acca24a..c4b377a394d1 100644 --- a/pkg/sql/logictest/testdata/logic_test/upsert +++ b/pkg/sql/logictest/testdata/logic_test/upsert @@ -1317,8 +1317,23 @@ INSERT INTO generated_as_id_t (a, b) VALUES (1, 10) ON CONFLICT (a) DO UPDATE SE statement ok INSERT INTO generated_as_id_t (a, c) VALUES (1, 10) ON CONFLICT DO NOTHING -query III rowsort -SELECT * FROM generated_as_id_t ORDER BY a + +# Do this fancy query to deal with the fact that transaction restarts on the +# insert may change the sequence values used for columns b and c. This query +# just ensures that they have the expected offset from each other. +query III + SELECT a, + b - b_min + 1 AS b, + c - c_min + 1 AS c + FROM generated_as_id_t, + ( + SELECT b AS b_min, + c AS c_min + FROM generated_as_id_t + ORDER BY a ASC + LIMIT 1 + ) +ORDER BY a ---- 1 1 1 2 2 2