From ac74be9665c7d6e498025159b7df6576d04119de Mon Sep 17 00:00:00 2001 From: Daniel Harrison Date: Tue, 23 Apr 2019 07:42:06 -0700 Subject: [PATCH] changefeedccl: log more details when returning with non-retryable errors The `%v` and `%+v` were switched from what I intended in the line that logs retryable errors and the one that handles non-retryable errors. Release note: None --- pkg/ccl/changefeedccl/changefeed_stmt.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/ccl/changefeedccl/changefeed_stmt.go b/pkg/ccl/changefeedccl/changefeed_stmt.go index be38449b48fe..b3f216d26322 100644 --- a/pkg/ccl/changefeedccl/changefeed_stmt.go +++ b/pkg/ccl/changefeedccl/changefeed_stmt.go @@ -456,11 +456,11 @@ func (b *changefeedResumer) Resume( return nil } if !IsRetryableError(err) { - log.Warningf(ctx, `CHANGEFEED job %d returning with error: %v`, jobID, err) + log.Warningf(ctx, `CHANGEFEED job %d returning with error: %+v`, jobID, err) return err } - log.Warningf(ctx, `CHANGEFEED job %d encountered retryable error: %+v`, jobID, err) + log.Warningf(ctx, `CHANGEFEED job %d encountered retryable error: %v`, jobID, err) if metrics, ok := execCfg.JobRegistry.MetricsStruct().Changefeed.(*Metrics); ok { metrics.ErrorRetries.Inc(1) }