Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance regression in execStmtInOpenState #102398

Open
srosenberg opened this issue Apr 27, 2023 · 3 comments
Open

performance regression in execStmtInOpenState #102398

srosenberg opened this issue Apr 27, 2023 · 3 comments
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@srosenberg
Copy link
Member

srosenberg commented Apr 27, 2023 •
edited by exalate-issue-sync bot
Loading

Split from #101299

A performance regression of ~3-5% was observed in execStmtInOpenState. The flamegraphs below suggest the regression was caused by [1].

Before the change (baseline commit is a3d53668ff5),

execStmtInOpenState_before

After the change,

execStmtInOpenState_after

[1] #99663

Jira issue: CRDB-27421
@srosenberg srosenberg added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Apr 27, 2023
@srosenberg srosenberg mentioned this issue Apr 27, 2023
Closed
@srosenberg
Copy link
Member Author

@cockroachdb/sql-sessions

@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Apr 27, 2023
@rafiss
Copy link
Collaborator

rafiss commented May 9, 2023

@ecwall since you're on call right now, could you pick this up to see where the extra time is being spent? depending on what you find, we can work on a fix now, or plan the work for later.

@ecwall
Copy link
Contributor

ecwall commented May 10, 2023

Reproduction steps here #101299 (comment)

Note:

be careful with the workload gen.; best to build it from master because there was a previously known regression which limits workload’s throughput generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rafiss @srosenberg @ecwall