Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add support for ARRAY indexing #10518

Closed
nvanbenschoten opened this issue Nov 7, 2016 · 5 comments
Closed

sql: add support for ARRAY indexing #10518

nvanbenschoten opened this issue Nov 7, 2016 · 5 comments
Assignees
@nvanbenschoten
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL

Comments

@nvanbenschoten
Copy link
Member

Subissue of #2115.
See https://www.postgresql.org/docs/9.6/static/arrays.html#ARRAYS-ACCESSING.

We currently have basic support for ARRAYs at the SQL interpreter level, but we do not support array indexing. We should add this support to permit proper functionality of Hibernate.
@nvanbenschoten nvanbenschoten added the A-sql-pgcompat Semantic compatibility with PostgreSQL label Nov 7, 2016
@nvanbenschoten nvanbenschoten self-assigned this Nov 7, 2016
@nvanbenschoten nvanbenschoten changed the title sql: add support for array indexing sql: add support for ARRAY indexing Nov 7, 2016
@knz
Copy link
Contributor

knz commented Nov 26, 2016

wasn't this fixed by #10669?

@knz
Copy link
Contributor

knz commented Nov 26, 2016

Closing this for now, re-open if I misunderstood something.

@knz knz closed this as completed Nov 26, 2016
@nvanbenschoten
Copy link
Member Author

The change you referenced added support for indexing array expressions, but not array columns. I'm going to reopen this for now and close it once that second need is met.

@nvanbenschoten nvanbenschoten reopened this Dec 2, 2016
@knz
Copy link
Contributor

knz commented Dec 2, 2016

Oh I just opened #11790 to react to Jordan's question on this. What do we do? Close one of the issues as dup of the other?

@nvanbenschoten
Copy link
Member Author

Yes it looks like this can be closed in favor of the more specific issue. Thanks!

@petermattis petermattis mentioned this issue Feb 10, 2017
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvanbenschoten nvanbenschoten

Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@knz @nvanbenschoten