Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel,dev: make sure dev supports different --compilation_modes, maybe capture in doctor #106932

Closed
rickystewart opened this issue Jul 17, 2023 · 1 comment
Closed

bazel,dev: make sure dev supports different --compilation_modes, maybe capture in doctor #106932

rickystewart opened this issue Jul 17, 2023 · 1 comment
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Comments

@rickystewart
Copy link
Collaborator

rickystewart commented Jul 17, 2023 •
edited by cockroach-jira-scripts
Loading

In a recent rules_go update, the behavior of fastbuild apparently changed, making it so that builds using this compilation mode are stripped.

You can build a non-stripped executable with -c dbg, but dev doesn't know about the --compilation_mode and stages the wrong binary in this case.

Also consider having dev doctor report that one should set -c dbg (wouldn't one always want this?)

Epic: CRDB-17171

Jira issue: CRDB-29769
@rickystewart rickystewart added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-build-system T-dev-inf labels Jul 17, 2023
@rickystewart
Copy link
Collaborator Author

Whoops, this is a dupe of #106820. My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rickystewart