Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run nightly benchmark for row level TTL #107496

Closed
rimadeodhar opened this issue Jul 24, 2023 · 3 comments · Fixed by #107959
Closed

Run nightly benchmark for row level TTL #107496

rimadeodhar opened this issue Jul 24, 2023 · 3 comments · Fixed by #107959
Assignees
@rafiss
Labels
A-row-level-ttl A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@rimadeodhar
Copy link
Collaborator

rimadeodhar commented Jul 24, 2023 •
edited by cockroach-jira-scripts
Loading

We should run a nightly benchmark for row level TTL using the workload added in #87449.

Jira issue: CRDB-30081
@rimadeodhar rimadeodhar added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Jul 24, 2023
@dikshant
Copy link

It would also be good to have a foreground workload on these tests and measure how much they are impacted. For example, what does the P95 INSERT/SELECT/UPDATE look like when TTL is running.

@rafiss
Copy link
Collaborator

rafiss commented Jul 25, 2023

The ttlbench workload in #87449 just tests the TTL job itself.

The ttllogger workload (https://github.com/cockroachdb/cockroach/blob/master/pkg/workload/ttllogger/ttllogger.go) is one that tests TTL while INSERTs are happening.

Both of these are valuable. For the nightly, lets see if we can use those or extend them further to reproduce issues like #98722

@rafiss rafiss added A-testing Testing tools and infrastructure A-row-level-ttl labels Jul 25, 2023
@rafiss
Copy link
Collaborator

rafiss commented Jul 27, 2023

https://github.com/cockroachlabs/support/issues/2469 has examples of the kind of behavior we want to test in our nightlies.

@rafiss rafiss mentioned this issue Jul 28, 2023
Closed
@rafiss rafiss self-assigned this Jul 31, 2023
@rafiss rafiss mentioned this issue Aug 1, 2023
Merged
@craig craig bot closed this as completed in 70a5801 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafiss rafiss

Labels
A-row-level-ttl A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachtest: add row-level-ttl/during/tpcc test rafiss/cockroach
3 participants
@rafiss @dikshant @rimadeodhar