Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/demo: the \demo recommission command has become non-sensical since v20.2 #108563

Closed
knz opened this issue Aug 10, 2023 · 0 comments · Fixed by #108566
Closed

cli/demo: the \demo recommission command has become non-sensical since v20.2 #108563

knz opened this issue Aug 10, 2023 · 0 comments · Fixed by #108566
Assignees
Labels
A-demo C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@knz
Copy link
Contributor

knz commented Aug 10, 2023

In v20.2 we have introduced the 2-step state transition decommissioning -> decommissioned.
once a node is in the "decommissioned" state the state is permanent -- i.e. it cannot be recommissioned.

Meanwhile, the \demo decommission command performs both state changes i.e. it has become unrecoverable since v20.2.

This means that \demo recommission simply cannot exist any more. It should be removed.

Epic: CRDB-28893

Jira issue: CRDB-30522

@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-demo labels Aug 10, 2023
@knz knz self-assigned this Aug 10, 2023
@craig craig bot closed this as completed in 9ac5f22 Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-demo C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant