Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance regression SQLStatsCollector in caused by a792cd3 #110170

Closed
srosenberg opened this issue Sep 7, 2023 · 1 comment · Fixed by #110174
Closed

performance regression SQLStatsCollector in caused by a792cd3 #110170

srosenberg opened this issue Sep 7, 2023 · 1 comment · Fixed by #110174
Assignees
@j82w
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-performance Perf of queries or internals. Solution not expected to change functional behavior. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.

Comments

@srosenberg
Copy link
Member

srosenberg commented Sep 7, 2023 •
edited by cockroach-jira-scripts
Loading

The root cause and its analysis are explained in [1]. Near term, the offending commit should be reverted. Long term, we should investigate switching to an atomic map.

[1] #109443

Jira issue: CRDB-31297
@srosenberg srosenberg added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-performance Perf of queries or internals. Solution not expected to change functional behavior. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-cluster-observability labels Sep 7, 2023
@blathers-crl
Copy link

blathers-crl bot commented Sep 7, 2023

Hi @srosenberg, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@j82w j82w mentioned this issue Sep 7, 2023
Merged
@craig craig bot closed this as completed in dbab89e Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j82w j82w

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-performance Perf of queries or internals. Solution not expected to change functional behavior. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "ssmemstorage: improve lock contention on RecordStatement"
2 participants
@srosenberg @j82w