Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: investigate the output of Hibernates' org.hibernate.test.batch.BatchTest #26812

Closed
BramGruneir opened this issue Jun 18, 2018 · 5 comments
Closed
Labels
A-tools-hibernate Issues that pertain to Hibernate integration. C-investigation Further steps needed to qualify. C-label will change.

Comments

@BramGruneir
Copy link
Member

There is a default jdbcBatchSize that seems to be set for Postgres but not for cockroach. More investigation is needed.

See the tests:

  • org.hibernate.test.batch.BatchTest
    • testBatchInsertUpdate
    • testBatchInsertUpdateSizeEqJdbcBatchSize

By defaulting to 0, there just might be a missing setting or something simple. Seems like this isn't supplied by postgres directly.

@BramGruneir BramGruneir added C-investigation Further steps needed to qualify. C-label will change. A-tools-hibernate Issues that pertain to Hibernate integration. labels Jun 18, 2018
@knz
Copy link
Contributor

knz commented Jun 30, 2018

@BramGruneir This issue is improperly qualified. It does neither state what is the deviation (difference between expected behavior and actual behavior) nor what action items should be carried out.

Unless you provide either (preferably both), we can't do anything with this.

@knz knz added the X-unactionable This was closed because it was unactionable. label Jun 30, 2018
@BramGruneir
Copy link
Member Author

I disagree. This is labeled as investigation. An investigation is actionable.

In this case, as specified, the default seems to be set to 0

My guess is that this is an issue with hibernate and not cockroach. But a more thorough investigation is required.

@BramGruneir BramGruneir removed the X-unactionable This was closed because it was unactionable. label Jul 2, 2018
@knz
Copy link
Contributor

knz commented Jul 2, 2018

Define:

  • What is a "batch" in JDBC/Hibernate. How does it correspond to SQL.
  • How is the batch size determined. How this determination is made in SQL or in the wire protocol.

@knz knz changed the title sql: Hibernate jdbcBatchSize not set sql: investigate the output of Hibernates' org.hibernate.test.batch.BatchTest Jul 2, 2018
@knz
Copy link
Contributor

knz commented Jul 2, 2018

The issue title was wrong.

We do not really know what the issue is so the title must reflect the investigation not the working theory as to the source of the problem.

@jordanlewis
Copy link
Member

Fixed as of 2.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tools-hibernate Issues that pertain to Hibernate integration. C-investigation Further steps needed to qualify. C-label will change.
Projects
None yet
Development

No branches or pull requests

3 participants