Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: Save store directories on failure #36640

Closed
bdarnell opened this issue Apr 9, 2019 · 1 comment
Closed

roachtest: Save store directories on failure #36640

bdarnell opened this issue Apr 9, 2019 · 1 comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale

Comments

@bdarnell
Copy link
Contributor

bdarnell commented Apr 9, 2019

Occasionally roachtests will fail in a way that is hard to reproduce (Current example: #35986. Past example: #32166). These failures often don't include enough information to tell what's going on; the store directories would be extremely helpful. I think we should tar up all the data directories for failed roachtests and upload them to s3/gce. (with maybe a 1-week expiration)

This will have a cost, but I think it'll be cheaper than the repeated runs we have to do to reproduce rare failures. It might be even better to keep the VMs running for inspection, but that would be much more expensive. I think saving the store directories has the better cost/benefit.

@awoods187 awoods187 added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Apr 22, 2019
@kenliu kenliu added the A-testing Testing tools and infrastructure label Jul 12, 2019
@github-actions
Copy link

github-actions bot commented Jun 4, 2021

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
5 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale
Projects
None yet
Development

No branches or pull requests

3 participants