Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: use pebble sst builder to write ssts for snapshots #39748

Closed
jeffrey-xiao opened this issue Aug 19, 2019 · 4 comments
Closed

storage: use pebble sst builder to write ssts for snapshots #39748

jeffrey-xiao opened this issue Aug 19, 2019 · 4 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@jeffrey-xiao
Copy link
Contributor

We are already using pebble's sst builder to write ssts in bulk (#37528) and we can do the same for snapshots. There is some additional work to support incrementally writing ssts (I.E. truncating the sst after a certain size threshold) and range deletion tombstones.
@petermattis
Copy link
Collaborator

There is some additional work to support incrementally writing ssts (I.E. truncating the sst after a certain size threshold) and range deletion tombstones.

Can you elaborate on this extra work? Is this additional functionality needed in the Pebble sstable.Writer, or something else?

@jeffrey-xiao
Copy link
Contributor Author

I think the additional work is adding functionality to pkg/storage/bulk/sst_writer.go, but I'll look into it.

@jeffrey-xiao jeffrey-xiao mentioned this issue Aug 21, 2019
Closed
@awoods187 awoods187 added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Aug 30, 2019
@ajwerner
Copy link
Contributor

@itsbilal does #42252 fix this?

@itsbilal
Copy link
Member

@ajwerner Yes, it does. Snapshots are written with the pebble writer now. Thanks for digging this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use bulk.SSTWriter to write SSTs on the receiver side jeffrey-xiao/cockroach
5 participants
@itsbilal @ajwerner @petermattis @jeffrey-xiao @awoods187