Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demo: add flags for each of the topology patterns that start them by default in Cockroach Demo #39945

Closed
awoods187 opened this issue Aug 23, 2019 · 3 comments
Closed

demo: add flags for each of the topology patterns that start them by default in Cockroach Demo #39945

awoods187 opened this issue Aug 23, 2019 · 3 comments
Assignees
@rohany
Labels
A-demo C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@awoods187
Copy link
Contributor

Let's add flags to cockroach demo that correspond to each of the topology patterns.

Something like:

--Geo-partitioned-replicas
--Geo-partitioned-leaseholders
--Duplicate-indexes
--Follower-reads
--Follow-the-workload

Then you start Cockroach Demo with a command like this:
./cockroach demo --nodes 3 --geo-partitioned-replicas

And it's perfectly set up to work with load running by default. So this would include enterprise license and organization, localities, webui node map, partitioned tables, all with load directly running and visible in the webui.
@awoods187 awoods187 changed the title cli: add flags for each of the topology patterns that start them by default in Cockroach Demo demo: add flags for each of the topology patterns that start them by default in Cockroach Demo Aug 23, 2019
@awoods187 awoods187 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cli labels Aug 23, 2019
@awoods187 awoods187 mentioned this issue Aug 23, 2019
Closed
12 tasks
@rohany rohany self-assigned this Aug 28, 2019
@rohany
Copy link
Contributor

rohany commented Aug 28, 2019

Do we have any docs/scripts somewhere that have the setup commands needed for setting up these topologies?

@awoods187
Copy link
Contributor Author

https://cockroachlabs.atlassian.net/wiki/spaces/ENG/pages/165544052/Topology+Pattern+Tutorials

As discussed offline, let's just try this out with partitioning before expanding further.

@rohany rohany mentioned this issue Aug 29, 2019
Merged
rohany added a commit to rohany/cockroach that referenced this issue Aug 29, 2019
@rohany
demo: Add a flag to automatically apply geo-partitioned replicas.
0ad176f 
Work for cockroachdb#39945.

Release note (cli change): Add an option for cockroach demo to
automatically apply the geo-partitioned replicas topology to the movr
dataset.
rohany added a commit to rohany/cockroach that referenced this issue Sep 1, 2019
@rohany
demo: Add a flag to automatically apply geo-partitioned replicas.
31b9132 
Work for cockroachdb#39945.

Release note (cli change): Add an option for cockroach demo to
automatically apply the geo-partitioned replicas topology to the movr
dataset.
rohany added a commit to rohany/cockroach that referenced this issue Sep 10, 2019
@rohany
demo: Add a flag to automatically apply geo-partitioned replicas.
54b530a 
Work for cockroachdb#39945.

Release note (cli change): Add an option for cockroach demo to
automatically apply the geo-partitioned replicas topology to the movr
dataset.
rohany added a commit to rohany/cockroach that referenced this issue Sep 11, 2019
@rohany
demo: Add a flag to automatically apply geo-partitioned replicas.
1c17b91 
Work for cockroachdb#39945.

This PR adds a Partition function to the workload.Hooks struct so that
workloads that have a partitioning step can just implement that function
within the workload package.

Release note (cli change): Add an option for cockroach demo to
automatically apply the geo-partitioned replicas topology to the movr
dataset.
rohany added a commit to rohany/cockroach that referenced this issue Sep 11, 2019
@rohany
demo: Add a flag to automatically apply geo-partitioned replicas.
c1098cf 
Work for cockroachdb#39945.

This PR adds a Partition function to the workload.Hooks struct so that
workloads that have a partitioning step can just implement that function
within the workload package.

Release note (cli change): Add an option for cockroach demo to
automatically apply the geo-partitioned replicas topology to the movr
dataset.
rohany added a commit to rohany/cockroach that referenced this issue Sep 12, 2019
@rohany
demo: Add a flag to automatically apply geo-partitioned replicas.
6e193b6 
Work for cockroachdb#39945.

This PR adds a Partition function to the workload.Hooks struct so that
workloads that have a partitioning step can just implement that function
within the workload package.

Release note (cli change): Add an option for cockroach demo to
automatically apply the geo-partitioned replicas topology to the movr
dataset.
rohany added a commit to rohany/cockroach that referenced this issue Sep 12, 2019
@rohany
demo: Add a flag to automatically apply geo-partitioned replicas.
10345ee 
Work for cockroachdb#39945.

This PR adds a Partition function to the workload.Hooks struct so that
workloads that have a partitioning step can just implement that function
within the workload package.

Release note (cli change): Add an option for cockroach demo to
automatically apply the geo-partitioned replicas topology to the movr
dataset using the --geo-partitioned-replicas flag.
craig bot pushed a commit that referenced this issue Sep 12, 2019
@rohany
Merge #40355
34e9175 
40355: demo: Add option to automatically apply the Geo-Partitioned Replicas topology to Movr r=rohany a=rohany

Work for #39945.

This PR adds a Partition function to the workload.Hooks struct so that
workloads that have a partitioning step can just implement that function
within the workload package.

Release note (cli change): Add an option for cockroach demo to
automatically apply the geo-partitioned replicas topology to the movr
dataset using the --geo-partitioned-replicas flag.


Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
ajwerner pushed a commit to ajwerner/cockroach that referenced this issue Sep 13, 2019
@rohany @ajwerner
demo: Add a flag to automatically apply geo-partitioned replicas.
2ec3b13 
Work for cockroachdb#39945.

This PR adds a Partition function to the workload.Hooks struct so that
workloads that have a partitioning step can just implement that function
within the workload package.

Release note (cli change): Add an option for cockroach demo to
automatically apply the geo-partitioned replicas topology to the movr
dataset using the --geo-partitioned-replicas flag.
@asubiotto
Copy link
Contributor

Closing because I'm pretty sure this has been implemented. @rohany feel free to reopen if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohany rohany

Labels
A-demo C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asubiotto @rohany @awoods187