Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry events do not file github issues any more #40412

Closed
knz opened this issue Sep 2, 2019 · 6 comments
Closed

Sentry events do not file github issues any more #40412

knz opened this issue Sep 2, 2019 · 6 comments
Assignees
Labels
A-monitoring C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-3-productivity Severe issues that impede the productivity of CockroachDB developers.

Comments

@knz
Copy link
Contributor

knz commented Sep 2, 2019

Describe the problem

Sentry is not filing github issues for new events since June approximately.

Yet the sentry-zapier interface seems configured properly: a manual check at https://sentry.io/settings/cockroach-labs/projects/cockroachdb/plugins/webhooks/ will correctly cause a github issue.

It's possible that the webhook API is not used by sentry any more?

To Reproduce

  • search sentry for issues with "firstseen" less than 1 month: observe that there are many recent issues; none of them have an accompanying github issue
  • search github for issues with label O-sentry. No issue was auto-filed since June.

Expected behavior

New events in Sentry should file github issues.

@knz knz added A-monitoring C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-3-productivity Severe issues that impede the productivity of CockroachDB developers. labels Sep 2, 2019
@knz
Copy link
Contributor Author

knz commented Sep 2, 2019

cc @andy-kimball I think this needs to be escalated to SIG - it impairs our ability to improve product stability.

@kenliu
Copy link

kenliu commented Sep 3, 2019

possibly related to #40414

@bobvawter
Copy link
Member

The sentry configuration is set to trigger alerts only if the incoming environment value is set to the exact value of release. It looks like we're currently sending the git tag as the environment value, so the integration alert isn't actually firing for any new code. I've temporarily set the alert to match on "issue first reported" in "all environments" to verify that the plumbing is still working. Will dig into crdb code to see why we're not getting the expected string value.

#40514 just came in from development, so the webhook wiring is still ok.

@bobvawter
Copy link
Member

I've tweaked the alert configuration to include all environments that start with "v", to match the released binaries.

@knz
Copy link
Contributor Author

knz commented Sep 10, 2019

Do we have a way to get confidence your new setting fixed the problem entirely?

@kenliu
Copy link

kenliu commented Oct 15, 2019

@bobvawter and I discussed, this is working again

@kenliu kenliu closed this as completed Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-monitoring C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-3-productivity Severe issues that impede the productivity of CockroachDB developers.
Projects
None yet
Development

No branches or pull requests

3 participants