Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colexec: add projections for TIMESTAMP #42044

Closed
yuzefovich opened this issue Oct 30, 2019 · 2 comments · Fixed by #44609
Closed

colexec: add projections for TIMESTAMP #42044

yuzefovich opened this issue Oct 30, 2019 · 2 comments · Fixed by #44609
Assignees
@yuzefovich
Labels
A-sql-vec SQL vectorized engine C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@yuzefovich
Copy link
Member

When #41662 is merged, we will have the support for TIMESTAMP type, but projections with timestamps will not be supported because other types (like INTERVAL) that are alongside the timestamps in the binary operations are still unsupported.
@yuzefovich yuzefovich added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Oct 30, 2019
@yuzefovich yuzefovich added the A-sql-vec SQL vectorized engine label Oct 30, 2019
@jordanlewis
Copy link
Member

Surely we can still support stuff like timestamp < timestamp right? Comparison projections.

@yuzefovich
Copy link
Member Author

Yes, the comparison (between two timestamps) operator projections should work, but the binary operator projections are missing (since those exist only with unsupported types).

@asubiotto asubiotto mentioned this issue Nov 19, 2019
Closed
@yuzefovich yuzefovich mentioned this issue Jan 30, 2020
Merged
@yuzefovich yuzefovich self-assigned this Feb 1, 2020
@yuzefovich yuzefovich mentioned this issue Feb 1, 2020
Merged
@craig craig bot closed this as completed in fae48aa Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
A-sql-vec SQL vectorized engine C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

colexec: add support for Interval-related projections yuzefovich/cockroach
2 participants
@jordanlewis @yuzefovich