Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: the call to GetPreventedStartupMessage is not in the right place #44041

Closed
knz opened this issue Jan 15, 2020 · 0 comments · Fixed by #47756
Closed

cli: the call to GetPreventedStartupMessage is not in the right place #44041

knz opened this issue Jan 15, 2020 · 0 comments · Fixed by #47756
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@knz
Copy link
Contributor

knz commented Jan 15, 2020

The log.Fatal accompanying the function GetPreventedStartupMessage is called either too early or too late:

  • arguably it should be called before forking to the background
  • if not, it should be called after the logging subsystem has been initialized. Also probably with log.Shout followed by log.Exit instead of log.Fatal.
@knz knz added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. A-cli labels Jan 15, 2020
@knz knz mentioned this issue Apr 21, 2020
Merged
@craig craig bot closed this as completed in 998abbe Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli,base: surface stored critical errors at the right moment knz/cockroach
1 participant
@knz