Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errorutils: UnsupportedWithMultiTenancy is incomplete #48164

Closed
knz opened this issue Apr 29, 2020 · 0 comments · Fixed by #54256
Closed

errorutils: UnsupportedWithMultiTenancy is incomplete #48164

knz opened this issue Apr 29, 2020 · 0 comments · Fixed by #54256
Assignees
@tbg
Labels
A-multitenancy Related to multi-tenancy C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@knz
Copy link
Contributor

knz commented Apr 29, 2020

The function should follow the lead of the unimplemented package and:

  1. define a suitable leaf error type,
  2. populate a pg error code,
  3. add the IssueLink annotations to get the proper issue URLs
  4. add telemetry.

Found while working on #48040

cc @tbg
@knz knz added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label Apr 29, 2020
@tbg tbg self-assigned this Apr 29, 2020
@tbg tbg added the A-multitenancy Related to multi-tenancy label Apr 29, 2020
@knz knz mentioned this issue Sep 11, 2020
Merged
@craig craig bot closed this as completed in 40f03d9 Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbg tbg

Labels
A-multitenancy Related to multi-tenancy C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: make multi-tenancy errors report to telemetry knz/cockroach
2 participants
@knz @tbg