Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: support COLLATE "default" in SELECT queries #50734

Closed
rafiss opened this issue Jun 27, 2020 · 0 comments · Fixed by #96828
Closed

sql: support COLLATE "default" in SELECT queries #50734

rafiss opened this issue Jun 27, 2020 · 0 comments · Fixed by #96828
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@rafiss
Copy link
Collaborator

rafiss commented Jun 27, 2020 •
edited by cockroach-jira-scripts
Loading

Postgres allows a COLLATE clause to appear at the end of an expression. See: https://www.postgresql.org/docs/12/sql-expressions.html#SQL-SYNTAX-COLLATE-EXPRS

CockroachDB doesn't support COLLATE in general right now, but some tools (e.g. Prisma) use COLLATE "default" in their queries, which it seems does not differ from the behavior of not having any COLLATE clause at all.

CockroachDB should support a default COLLATE expression.

Jira issue: CRDB-4095
@rafiss rafiss added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-pgcompat Semantic compatibility with PostgreSQL labels Jun 27, 2020
@awoods187 awoods187 mentioned this issue Jun 29, 2020
Closed
2 tasks
@janpio janpio mentioned this issue Aug 5, 2020
Closed
@rafiss rafiss mentioned this issue Dec 1, 2020
Open
@rafiss rafiss added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 12, 2021
@rafiss rafiss mentioned this issue Sep 21, 2022
Closed
@rafiss rafiss mentioned this issue Feb 8, 2023
Merged
@craig craig bot closed this as completed in 732c3a7 Feb 9, 2023
@rafiss rafiss mentioned this issue Feb 21, 2023
Merged
@cockroach-teamcity cockroach-teamcity mentioned this issue Feb 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

collatedstring: support default, C, and POSIX in expressions rafiss/cockroach
1 participant
@rafiss