Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: cache ImmutableTableDescriptor #55960

Closed
yuzefovich opened this issue Oct 25, 2020 · 2 comments
Closed

sql: cache ImmutableTableDescriptor #55960

yuzefovich opened this issue Oct 25, 2020 · 2 comments
Labels
C-performance Perf of queries or internals. Solution not expected to change functional behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@yuzefovich
Copy link
Member

yuzefovich commented Oct 25, 2020

Extracting the second observation from #42770:

  1. We always construct a new ImmutableTableDescriptor. These things are meant to be cached. I'm not sure how best to plumb a cache (or which one).

cc @ajwerner as I think you've been thinking about this and possibly there already exists a better issue.

Jira issue: CRDB-3608

@yuzefovich yuzefovich added the C-performance Perf of queries or internals. Solution not expected to change functional behavior. label Oct 25, 2020
@ajwerner
Copy link
Contributor

I started to hack on this in #53747. I'll work to get that over the finish line. I think that that should enable us to cache even more inside the ImmutableTableDescriptor.

@jlinder jlinder added the T-sql-schema-deprecated Use T-sql-foundations instead label Jun 16, 2021
@postamar
Copy link
Contributor

postamar commented Mar 8, 2022

We now do effectively cache these in the descriptors collection. The exception to the rule are the table descriptors based on the protos in the distsql specs, which ultimately could be replaced by an (ID,Version) pair used to look them up in the descriptors collection.

@postamar postamar closed this as completed Mar 8, 2022
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-performance Perf of queries or internals. Solution not expected to change functional behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

No branches or pull requests

4 participants