Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/colexec: TestHashRouterRandom failed #58956

Closed
cockroach-teamcity opened this issue Jan 13, 2021 · 3 comments · Fixed by #59057
Closed

sql/colexec: TestHashRouterRandom failed #58956

cockroach-teamcity opened this issue Jan 13, 2021 · 3 comments · Fixed by #59057
Assignees
@yuzefovich @asubiotto
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. skipped-test

Comments

@cockroach-teamcity
Copy link
Member

(sql/colexec).TestHashRouterRandom failed on master@b9eb459b18369041f9e67c4830aa316e9d2ca0f0:

=== RUN   TestHashRouterRandom
    test_log_scope.go:72: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestHashRouterRandom996257729
    test_log_scope.go:73: use -show-logs to present logs inline
=== CONT  TestHashRouterRandom
    routers_test.go:1204: -- test log scope end --
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestHashRouterRandom996257729
--- FAIL: TestHashRouterRandom (12.45s)
=== RUN   TestHashRouterRandom/terminationScenario=0/numOutputs=45/blockedThreshold=9093/totalInputSize=11180/hashCols=[0_1]/memoryLimit=37_MiB
    routers_test.go:1133: unexpected number of results 11077, expected 11180
    --- FAIL: TestHashRouterRandom/terminationScenario=0/numOutputs=45/blockedThreshold=9093/totalInputSize=11180/hashCols=[0_1]/memoryLimit=37_MiB (1.46s)
=== RUN   TestHashRouterRandom/terminationScenario=0/numOutputs=45/blockedThreshold=9093/totalInputSize=11180/hashCols=[0_1]/memoryLimit=1.0_GiB
    routers_test.go:1133: unexpected number of results 11178, expected 11180
    --- FAIL: TestHashRouterRandom/terminationScenario=0/numOutputs=45/blockedThreshold=9093/totalInputSize=11180/hashCols=[0_1]/memoryLimit=1.0_GiB (2.08s)
More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestHashRouterRandom PKG=./pkg/sql/colexec TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jan 13, 2021
@cockroach-teamcity
Copy link
Member Author

(sql/colexec).TestHashRouterRandom failed on master@55d93310bc8f31c29435330617ca78be789899c5:

=== RUN   TestHashRouterRandom
    test_log_scope.go:72: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestHashRouterRandom800717486
    test_log_scope.go:73: use -show-logs to present logs inline
=== CONT  TestHashRouterRandom
    routers_test.go:1204: -- test log scope end --
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestHashRouterRandom800717486
--- FAIL: TestHashRouterRandom (1.36s)
=== RUN   TestHashRouterRandom/terminationScenario=0/numOutputs=28/blockedThreshold=2997/totalInputSize=1284/hashCols=[0_1]/memoryLimit=8.2_MiB
    routers_test.go:1133: unexpected number of results 1273, expected 1284
    --- FAIL: TestHashRouterRandom/terminationScenario=0/numOutputs=28/blockedThreshold=2997/totalInputSize=1284/hashCols=[0_1]/memoryLimit=8.2_MiB (0.23s)
More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestHashRouterRandom PKG=./pkg/sql/colexec TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

RaduBerinde added a commit to RaduBerinde/cockroach that referenced this issue Jan 14, 2021
@RaduBerinde
sql/colexec: skip TestHashRouterRandom
60394f3 
Refs: cockroachdb#58956

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None
@RaduBerinde RaduBerinde mentioned this issue Jan 14, 2021
Merged
@yuzefovich
Copy link
Member

Oh, this might be another instance of #58935 which will hopefully be a lot easier to debug.

craig bot pushed a commit that referenced this issue Jan 14, 2021
@RaduBerinde
Merge #58986
f9b44f5 
58986: sql/colexec: skip TestHashRouterRandom r=yuzefovich a=RaduBerinde

Refs: #58956

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None

Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
@cockroach-teamcity
Copy link
Member Author

(sql/colexec).TestHashRouterRandom failed on master@5bd34572e489dea0fa67feedd7c499f0ad9f9ebd:

=== RUN   TestHashRouterRandom
    test_log_scope.go:72: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestHashRouterRandom232140531
    test_log_scope.go:73: use -show-logs to present logs inline
=== CONT  TestHashRouterRandom
    routers_test.go:1204: -- test log scope end --
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestHashRouterRandom232140531
--- FAIL: TestHashRouterRandom (2.72s)
=== RUN   TestHashRouterRandom/terminationScenario=0/numOutputs=11/blockedThreshold=2421/totalInputSize=3231/hashCols=[0]/memoryLimit=1.0_GiB
    routers_test.go:1133: unexpected number of results 3229, expected 3231
    --- FAIL: TestHashRouterRandom/terminationScenario=0/numOutputs=11/blockedThreshold=2421/totalInputSize=3231/hashCols=[0]/memoryLimit=1.0_GiB (0.31s)
=== RUN   TestHashRouterRandom/terminationScenario=0/numOutputs=11/blockedThreshold=2421/totalInputSize=3231/hashCols=[0]/memoryLimit=31_MiB
    routers_test.go:1133: unexpected number of results 3211, expected 3231
    --- FAIL: TestHashRouterRandom/terminationScenario=0/numOutputs=11/blockedThreshold=2421/totalInputSize=3231/hashCols=[0]/memoryLimit=31_MiB (0.44s)
More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestHashRouterRandom PKG=./pkg/sql/colexec TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

This was referenced Jan 15, 2021
Merged
Merged
@craig craig bot closed this as completed in fbf48db Jan 15, 2021
@craig craig bot closed this as completed in #59057 Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

@asubiotto asubiotto

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. skipped-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

colexec: fix coalescing logic in the spilling queue yuzefovich/cockroach
4 participants
@yuzefovich @asubiotto @RaduBerinde @cockroach-teamcity