Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: TestClosedTimestampCantServeForWritingTransaction panics #60288

Closed
andreimatei opened this issue Feb 10, 2021 · 1 comment · Fixed by #60023
Closed

kvserver: TestClosedTimestampCantServeForWritingTransaction panics #60288

andreimatei opened this issue Feb 10, 2021 · 1 comment · Fixed by #60023
Assignees
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered).

Comments

@andreimatei
Copy link
Contributor

After 24s of stressing on my machine:

=== RUN   TestClosedTimestampCantServeForWritingTransaction
    test_log_scope.go:73: test logs captured to: /tmp/logTestClosedTimestampCantServeForWritingTransaction946845855
    test_log_scope.go:74: use -show-logs to present logs inline
panic: descriptor is not initialized: r37:{-} [<no replicas>, next=0, gen=0]

goroutine 5669 [running]:
github.com/cockroachdb/cockroach/pkg/roachpb.NewRangeKeyMismatchError(0x535dee0, 0xc003e7f1d0, 0xc0026996c0, 0x3, 0x8, 0xc0026996c8, 0x2, 0x8, 0xc004700150, 0xc003d92aa0, ...)
        /home/andrei/src/github.com/cockroachdb/cockroach-2/pkg/roachpb/errors.go:561 +0x305
github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).checkSpanInRangeRLocked(0xc005306000, 0x535dee0, 0xc003e7f1d0, 0xc0026996c0, 0x3, 0x8, 0xc0026996c8, 0x2, 0x8, 0x0, ...)
        /home/andrei/src/github.com/cockroachdb/cockroach-2/pkg/kv/kvserver/replica.go:1282 +0x1bf
github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).checkExecutionCanProceed(0xc005306000, 0x535dee0, 0xc003e7f1d0, 0xc0046746e0, 0xc004700a80, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /home/andrei/src/github.com/cockroachdb/cockroach-2/pkg/kv/kvserver/replica.go:1200 +0x293
github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).executeReadOnlyBatch(0xc005306000, 0x535dee0, 0xc003e7f1d0, 0xc0046746e0, 0xc004700a80, 0x0, 0x0, 0x0)
        /home/andrei/src/github.com/cockroachdb/cockroach-2/pkg/kv/kvserver/replica_read.go:41 +0xf0
github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).executeBatchWithConcurrencyRetries(0xc005306000, 0x535dee0, 0xc003e7f1d0, 0xc0046746e0, 0x4cd7738, 0x0, 0x0)
        /home/andrei/src/github.com/cockroachdb/cockroach-2/pkg/kv/kvserver/replica_send.go:275 +0x336
github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).sendWithRangeID(0xc005306000, 0x535de20, 0xc006122840, 0x25, 0xc0046746e0, 0x64, 0x3fc3333333333333)
        /home/andrei/src/github.com/cockroachdb/cockroach-2/pkg/kv/kvserver/replica_send.go:91 +0x27f
github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).Send(...)
        /home/andrei/src/github.com/cockroachdb/cockroach-2/pkg/kv/kvserver/replica_send.go:34
github.com/cockroachdb/cockroach/pkg/kv/kvserver_test.verifyCanReadFromAllRepls.func1(0xc0032fd0d0, 0x4cddbc0)
        /home/andrei/src/github.com/cockroachdb/cockroach-2/pkg/kv/kvserver/closed_timestamp_test.go:1344 +0x245
golang.org/x/sync/errgroup.(*Group).Go.func1(0xc004b4f290, 0xc002e09320)
        /home/andrei/src/github.com/cockroachdb/cockroach-2/vendor/golang.org/x/sync/errgroup/errgroup.go:57 +0x59
created by golang.org/x/sync/errgroup.(*Group).Go
        /home/andrei/src/github.com/cockroachdb/cockroach-2/vendor/golang.org/x/sync/errgroup/errgroup.go:54 +0x66
@andreimatei andreimatei added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Feb 10, 2021
@andreimatei andreimatei added the C-test-failure Broken test (automatically or manually discovered). label Feb 10, 2021
@nvanbenschoten
Copy link
Member

Yeah, this is fixed by #60023. I missed @aayushshah15's rapid review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants