Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geo/wkt: update parsing of dimensions for empty GEOMETRYCOLLECTIONs #61035

Closed
andyyang890 opened this issue Feb 24, 2021 · 0 comments · Fixed by #61129
Closed

geo/wkt: update parsing of dimensions for empty GEOMETRYCOLLECTIONs #61035

andyyang890 opened this issue Feb 24, 2021 · 0 comments · Fixed by #61129
Assignees
@andyyang890
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@andyyang890
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

As described in twpayne/go-geom#189, it is not currently possible to distinguish between GEOMETRYCOLLECTIONs with different dimensions. Once that issue is fixed, the WKT parser will need to be updated to record the dimensions of GEOMETRYCOLLECTIONs.

Describe the solution you'd like
Update the WKT parser as described above.

Describe alternatives you've considered
N/A

Additional context
N/A
@andyyang890 andyyang890 added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Feb 24, 2021
@andyyang890 andyyang890 self-assigned this Feb 24, 2021
@andyyang890 andyyang890 mentioned this issue Feb 25, 2021
Merged
@craig craig bot closed this as completed in #61129 Feb 26, 2021
@craig craig bot closed this as completed in 8f612b4 Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyyang890 andyyang890

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

geo/wkt: update parsing of dimensions for empty geometrycollections andyyang890/cockroach
1 participant
@andyyang890