Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: move system.zones into the tenant keyspace #67014

Closed
arulajmani opened this issue Jun 29, 2021 · 3 comments · Fixed by #67323
Closed

sql: move system.zones into the tenant keyspace #67014

arulajmani opened this issue Jun 29, 2021 · 3 comments · Fixed by #67323
Assignees
Labels
A-multitenancy Related to multi-tenancy A-zone-configs C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@arulajmani
Copy link
Collaborator

arulajmani commented Jun 29, 2021

Is your feature request related to a problem? Please describe.

Part of #66348. We need to adsystem.zones for each tenant, and massage the existing zone config generation code to work off of descriptor IDs (instead of SystemTenantObjectIDs that it does today).

@arulajmani arulajmani added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-zone-configs A-multitenancy Related to multi-tenancy labels Jun 29, 2021
@arulajmani arulajmani self-assigned this Jun 29, 2021
@ajwerner
Copy link
Contributor

into the tenant keyspace and massage the existing zone config generation code to work on descriptor IDs (instead of system tenant object IDs as it does today).

I feel like this is a bit misleading. Is there really anything to be done? What is an object ID if not just a descriptor ID (plus some fake placeholder IDs)? What makes anything system tenant?

@arulajmani
Copy link
Collaborator Author

Is there really anything to be done? What is an object ID if not just a descriptor ID (plus some fake placeholder IDs)? What makes anything system tenant?

I was hoping to get rid of the concept of:

type SystemTenantObjectID uint32
once system.zones moves into the tenant keyspace. It's merely a wrapper around descriptor IDs, so there isn't much here other than cleaning up all places that convert descriptor IDs to this type.

@irfansharif
Copy link
Contributor

#67323.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-multitenancy Related to multi-tenancy A-zone-configs C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants