Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: Support 'COMMENT ON SCHEMA' #67689

Closed
13rac1 opened this issue Jul 15, 2021 · 6 comments · Fixed by #68606
Closed

sql: Support 'COMMENT ON SCHEMA' #67689

13rac1 opened this issue Jul 15, 2021 · 6 comments · Fixed by #68606
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-starter Might be suitable for a starter project for new employees or team members. good first issue O-community Originated from the community T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) X-blathers-triaged blathers was able to find an owner

Comments

@13rac1
Copy link

13rac1 commented Jul 15, 2021

Is your feature request related to a problem? Please describe.
COMMENT ON SCHEMA is not supported.

Describe the solution you'd like
COMMENT ON SCHEMA is supported.

Support for COMMENT ON for tables, table columns, and databases was implemented in 2019 for #19472 then the issue was closed by @jordanlewis because schemas were not supported at all: #19472 (comment)

This is done but for schemas which we don't support anyway - closing.

CREATE SCHEMA was implemented in 2020 #50613 therefore COMMENT ON SCHEMA is (should be?) unblocked. Might be a good first PR as there are examples in:

I may implement the PR, but am not claiming it yet.

Describe alternatives you've considered
I am skipping unsupported SQL.
@13rac1 13rac1 added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jul 15, 2021
@blathers-crl
Copy link

blathers-crl bot commented Jul 15, 2021

Hello, I am Blathers. I am here to help you get the issue triaged.

I have CC'd a few people who may be able to assist you:

If we have not gotten back to your issue within a few business days, you can try the following:

  • Join our community slack channel and ask on #cockroachdb.
  • Try find someone from here if you know they worked closely on the area and CC them.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Jul 15, 2021
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Jul 16, 2021
@jordanlewis
Copy link
Member

Thanks, you're absolutely right. Please feel free to take a stab at the PR!

@sagar23sj
Copy link

Hi, I would like to work on this PR.

@knz
Copy link
Contributor

knz commented Jul 26, 2021

we don't "reserve" PRs for one person. Anyone should free to work on it; you don't have to announce your work ahead of time.

@dheerajdlalwani
Copy link

Hey! I would like to work on this issue, but I have absolutely no clue where to start. Can someone point me to some relevant documentation/internal docs?

@knz
Copy link
Contributor

knz commented Aug 4, 2021

What about you look at the previous PRs that implemented COMMENT ON TABLE / COMMENT ON DATABASE, then do something similar.

@rafiss rafiss added the E-starter Might be suitable for a starter project for new employees or team members. label Aug 6, 2021
@ekalinin ekalinin mentioned this issue Aug 9, 2021
Merged
@craig craig bot closed this as completed in a60b8bb Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-starter Might be suitable for a starter project for new employees or team members. good first issue O-community Originated from the community T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) X-blathers-triaged blathers was able to find an owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: support COMMENT ON SCHEMA ekalinin/cockroach
6 participants
@jordanlewis @13rac1 @knz @rafiss @sagar23sj @dheerajdlalwani