Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: tlp failed #70483

Closed
cockroach-teamcity opened this issue Sep 21, 2021 · 10 comments
Closed

roachtest: tlp failed #70483

cockroach-teamcity opened this issue Sep 21, 2021 · 10 comments
Assignees
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-queries SQL Queries Team

Comments

@cockroach-teamcity
Copy link
Member

roachtest.tlp failed with artifacts on release-21.2 @ 5202c97fcfe7e51e244335c3cd68bd33647860ff:

The test failed on branch=release-21.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/tlp/run_1
	tlp.go:128,test_runner.go:777: expected unpartitioned count 4 to equal partitioned count 5
		(1) attached stack trace
		  -- stack trace:
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runTLPQuery.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/tlp.go:191
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runWithTimeout.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/tlp.go:203
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1371
		Wraps: (2) expected unpartitioned count 4 to equal partitioned count 5
		  | sql: SELECT count(*) FROM defaultdb.public.table1 AS tab_7665
		  | SELECT count(*) FROM (SELECT * FROM defaultdb.public.table1 AS tab_7665 WHERE tab_7665.col1_1 NOT SIMILAR TO tab_7665.crdb_internal_idx_expr UNION ALL SELECT * FROM defaultdb.public.table1 AS tab_7665 WHERE NOT (tab_7665.col1_1 NOT SIMILAR TO tab_7665.crdb_internal_idx_expr) UNION ALL SELECT * FROM defaultdb.public.table1 AS tab_7665 WHERE (tab_7665.col1_1 NOT SIMILAR TO tab_7665.crdb_internal_idx_expr) IS NULL)
		Error types: (1) *withstack.withStack (2) *errutil.leafError
Reproduce

See: roachtest README

Same failure on other branches

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

@cockroach-teamcity cockroach-teamcity added branch-release-21.2 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Sep 21, 2021
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Sep 21, 2021
@cucaroach cucaroach assigned cucaroach and mgartner and unassigned cucaroach Sep 21, 2021
@cucaroach
Copy link
Contributor

possibly char casting issue

@rytaft
Copy link
Collaborator

rytaft commented Sep 22, 2021

Not a release blocker

@rytaft rytaft removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Sep 22, 2021
@cockroach-teamcity
Copy link
Member Author

roachtest.tlp failed with artifacts on release-21.2 @ b3c1760a030791143c57e89c73d1f26ae8babaf5:

The test failed on branch=release-21.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/tlp/run_1
	tlp.go:128,test_runner.go:777: expected unpartitioned count 4 to equal partitioned count 5
		(1) attached stack trace
		  -- stack trace:
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runTLPQuery.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/tlp.go:191
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runWithTimeout.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/tlp.go:203
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1371
		Wraps: (2) expected unpartitioned count 4 to equal partitioned count 5
		  | sql: SELECT count(*) FROM defaultdb.public.table4 AS tab_27052
		  | SELECT count(*) FROM (SELECT * FROM defaultdb.public.table4 AS tab_27052 WHERE tab_27052.col4_6 UNION ALL SELECT * FROM defaultdb.public.table4 AS tab_27052 WHERE NOT (tab_27052.col4_6) UNION ALL SELECT * FROM defaultdb.public.table4 AS tab_27052 WHERE (tab_27052.col4_6) IS NULL)
		Error types: (1) *withstack.withStack (2) *errutil.leafError
Reproduce

See: roachtest README

Same failure on other branches

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.tlp failed with artifacts on release-21.2 @ 360956c1f727c600cbec55f457dd013d5fb6850b:

The test failed on branch=release-21.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/tlp/run_1
	tlp.go:128,test_runner.go:777: expected unpartitioned count 16 to equal partitioned count 4
		(1) attached stack trace
		  -- stack trace:
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runTLPQuery.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/tlp.go:191
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runWithTimeout.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/tlp.go:203
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1371
		Wraps: (2) expected unpartitioned count 16 to equal partitioned count 4
		  | sql: SELECT count(*) FROM defaultdb.public.table1 AS tab_2101
		  | SELECT count(*) FROM (SELECT * FROM defaultdb.public.table1 AS tab_2101 WHERE tab_2101.crdb_internal_idx_expr LIKE tab_2101.col1_12 UNION ALL SELECT * FROM defaultdb.public.table1 AS tab_2101 WHERE NOT (tab_2101.crdb_internal_idx_expr LIKE tab_2101.col1_12) UNION ALL SELECT * FROM defaultdb.public.table1 AS tab_2101 WHERE (tab_2101.crdb_internal_idx_expr LIKE tab_2101.col1_12) IS NULL)
		Error types: (1) *withstack.withStack (2) *errutil.leafError
Reproduce

See: roachtest README

Same failure on other branches

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.tlp failed with artifacts on release-21.2 @ a35bb95e35ebefb6019382991c7fa534d1d50e44:

The test failed on branch=release-21.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/tlp/run_1
	tlp.go:128,test_runner.go:777: expected unpartitioned count 28 to equal partitioned count 19
		(1) attached stack trace
		  -- stack trace:
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runTLPQuery.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/tlp.go:191
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runWithTimeout.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/tlp.go:203
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1371
		Wraps: (2) expected unpartitioned count 28 to equal partitioned count 19
		  | sql: SELECT count(*) FROM defaultdb.public.table1 AS tab_6627
		  | SELECT count(*) FROM (SELECT * FROM defaultdb.public.table1 AS tab_6627 WHERE (tab_6627.crdb_internal_mvcc_timestamp < tab_6627.crdb_internal_mvcc_timestamp) UNION ALL SELECT * FROM defaultdb.public.table1 AS tab_6627 WHERE NOT ((tab_6627.crdb_internal_mvcc_timestamp < tab_6627.crdb_internal_mvcc_timestamp)) UNION ALL SELECT * FROM defaultdb.public.table1 AS tab_6627 WHERE ((tab_6627.crdb_internal_mvcc_timestamp < tab_6627.crdb_internal_mvcc_timestamp)) IS NULL)
		Error types: (1) *withstack.withStack (2) *errutil.leafError
Reproduce

See: roachtest README

Same failure on other branches

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.tlp failed with artifacts on release-21.2 @ 81d49bd3d2e8ee3da4a5800043b94aa174127ab7:

The test failed on branch=release-21.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/tlp/run_1
	tlp.go:128,test_runner.go:777: expected unpartitioned count 0 to equal partitioned count 2
		(1) attached stack trace
		  -- stack trace:
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runTLPQuery.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/tlp.go:191
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runWithTimeout.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/tlp.go:203
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1581
		Wraps: (2) expected unpartitioned count 0 to equal partitioned count 2
		  | sql: SELECT count(*) FROM defaultdb.public.table1 AS tab_1802
		  | SELECT count(*) FROM (SELECT * FROM defaultdb.public.table1 AS tab_1802 WHERE e'+6\x07\x14\x18' ILIKE tab_1802.crdb_internal_idx_expr_2 UNION ALL SELECT * FROM defaultdb.public.table1 AS tab_1802 WHERE NOT (e'+6\x07\x14\x18' ILIKE tab_1802.crdb_internal_idx_expr_2) UNION ALL SELECT * FROM defaultdb.public.table1 AS tab_1802 WHERE (e'+6\x07\x14\x18' ILIKE tab_1802.crdb_internal_idx_expr_2) IS NULL)
		Error types: (1) *withstack.withStack (2) *errutil.leafError
Reproduce

See: roachtest README

Same failure on other branches

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.tlp failed with artifacts on release-21.2 @ 2282896401079fef362d5456b71b32dd600e52b0:

The test failed on branch=release-21.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/tlp/run_1
	tlp.go:128,test_runner.go:777: expected unpartitioned count 0 to equal partitioned count 1
		(1) attached stack trace
		  -- stack trace:
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runTLPQuery.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/tlp.go:191
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runWithTimeout.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/tlp.go:203
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1581
		Wraps: (2) expected unpartitioned count 0 to equal partitioned count 1
		  | sql: SELECT count(*) FROM defaultdb.public.table1 AS tab_1779
		  | SELECT count(*) FROM (SELECT * FROM defaultdb.public.table1 AS tab_1779 WHERE tab_1779.col1_7 NOT ILIKE tab_1779.crdb_internal_idx_expr_1 UNION ALL SELECT * FROM defaultdb.public.table1 AS tab_1779 WHERE NOT (tab_1779.col1_7 NOT ILIKE tab_1779.crdb_internal_idx_expr_1) UNION ALL SELECT * FROM defaultdb.public.table1 AS tab_1779 WHERE (tab_1779.col1_7 NOT ILIKE tab_1779.crdb_internal_idx_expr_1) IS NULL)
		Error types: (1) *withstack.withStack (2) *errutil.leafError
Reproduce

See: roachtest README

Same failure on other branches

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.tlp failed with artifacts on release-21.2 @ dc72c17f280dc20fa59970209c0e975e4072f91e:

The test failed on branch=release-21.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/tlp/run_1
	tlp.go:128,test_runner.go:777: expected unpartitioned count 2 to equal partitioned count 1
		(1) attached stack trace
		  -- stack trace:
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runTLPQuery.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/tlp.go:191
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runWithTimeout.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/tlp.go:203
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1581
		Wraps: (2) expected unpartitioned count 2 to equal partitioned count 1
		  | sql: SELECT count(*) FROM defaultdb.public.table5 AS tab_2622
		  | SELECT count(*) FROM (SELECT * FROM defaultdb.public.table5 AS tab_2622 WHERE st_summary('0102000080070000005CB1C4C4042BFF419351E1DB773FF8C1AFF512E43DF2F3C1B2DE296A0F780142F0A92D1E2F13D84140AA3969F359AB4180709B6EAAE7F741B63BD1F4CAB3F241E7488873E7E0F8C1B0D088BF2154F0C13C8CCB7A908FF64102B0FE740AFDF24157CACF5F5159F3C19AA31F2B5068F9413AC214A82BC1F34146C01DB40A72F0C104A850E3F601EF4148ED7303C845E741BFFA479DD55401C2CCF90B72B6F1EC41509C1581A3A4EFC1'::GEOMETRY)::STRING SIMILAR TO tab_2622.col5_1 UNION ALL SELECT * FROM defaultdb.public.table5 AS tab_2622 WHERE NOT (st_summary('0102000080070000005CB1C4C4042BFF419351E1DB773FF8C1AFF512E43DF2F3C1B2DE296A0F780142F0A92D1E2F13D84140AA3969F359AB4180709B6EAAE7F741B63BD1F4CAB3F241E7488873E7E0F8C1B0D088BF2154F0C13C8CCB7A908FF64102B0FE740AFDF24157CACF5F5159F3C19AA31F2B5068F9413AC214A82BC1F34146C01DB40A72F0C104A850E3F601EF4148ED7303C845E741BFFA479DD55401C2CCF90B72B6F1EC41509C1581A3A4EFC1'::GEOMETRY)::STRING SIMILAR TO tab_2622.col5_1) UNION ALL SELECT * FROM defaultdb.public.table5 AS tab_2622 WHERE (st_summary('0102000080070000005CB1C4C4042BFF419351E1DB773FF8C1AFF512E43DF2F3C1B2DE296A0F780142F0A92D1E2F13D84140AA3969F359AB4180709B6EAAE7F741B63BD1F4CAB3F241E7488873E7E0F8C1B0D088BF2154F0C13C8CCB7A908FF64102B0FE740AFDF24157CACF5F5159F3C19AA31F2B5068F9413AC214A82BC1F34146C01DB40A72F0C104A850E3F601EF4148ED7303C845E741BFFA479DD55401C2CCF90B72B6F1EC41509C1581A3A4EFC1'::GEOMETRY)::STRING SIMILAR TO tab_2622.col5_1) IS NULL)
		Error types: (1) *withstack.withStack (2) *errutil.leafError
Reproduce

See: roachtest README

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.tlp failed with artifacts on release-21.2 @ 0655d082b0d98f27e77471fcced8de94cd9327bc:

The test failed on branch=release-21.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/tlp/run_1
	tlp.go:128,test_runner.go:777: expected unpartitioned count 0 to equal partitioned count 2
		(1) attached stack trace
		  -- stack trace:
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runTLPQuery.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/tlp.go:191
		  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runWithTimeout.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/tlp.go:203
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1581
		Wraps: (2) expected unpartitioned count 0 to equal partitioned count 2
		  | sql: SELECT count(*) FROM defaultdb.public.table4 AS tab_17946
		  | SELECT count(*) FROM (SELECT * FROM defaultdb.public.table4 AS tab_17946 WHERE (tab_17946.col4_5 <= 0.5949851795460454) UNION ALL SELECT * FROM defaultdb.public.table4 AS tab_17946 WHERE NOT ((tab_17946.col4_5 <= 0.5949851795460454)) UNION ALL SELECT * FROM defaultdb.public.table4 AS tab_17946 WHERE ((tab_17946.col4_5 <= 0.5949851795460454)) IS NULL)
		Error types: (1) *withstack.withStack (2) *errutil.leafError
Reproduce

See: roachtest README

Same failure on other branches

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

@mgartner
Copy link
Collaborator

mgartner commented Jan 27, 2022

I reduced the last failure, which has the table:

CREATE TABLE table4 (
  col4_0 FLOAT8 NOT NULL, col4_1 REGNAMESPACE NOT NULL, col4_2 VARCHAR NULL, col4_3
"char" NOT NULL,
  PRIMARY KEY (col4_3 DESC, col4_1 ASC, col4_0),
  col4_4 STRING AS (lower(CAST(col4_1 AS STRING))) VIRTUAL NOT NULL,
  col4_5 FLOAT8 AS (col4_0 + 0.0) VIRTUAL NOT NULL,
  INDEX (lower(col4_3), col4_3) WHERE table4.col4_5 >= 5e-324
                                   OR table4.col4_0 = '-Inf',
  INDEX (col4_1 ASC, col4_2) WHERE table4.col4_3 > e'\U00002603'
                               AND table4.col4_4 < e'\x00',
  INDEX ((col4_0 + 0.014940481788108612) ASC, col4_1),
  FAMILY (col4_1, col4_3),
  FAMILY (col4_0, col4_2)
);

Notice the cast from col4_1 REGNAMESPACE to STRING in the computed column expression, which is is known to cause correctness issues. We likely won't be backporting a fix to 21.2 because it would break backward compatibility, but as of #75161, TLP should no longer rediscover this bug.

@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-queries SQL Queries Team
Projects
Archived in project
Development

No branches or pull requests

4 participants