Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: SET should report a warning/NOTICE when setting a custom var with the same name as a cluster setting #74375

Closed
knz opened this issue Jan 2, 2022 · 1 comment · Fixed by #76607
Closed

sql: SET should report a warning/NOTICE when setting a custom var with the same name as a cluster setting #74375

knz opened this issue Jan 2, 2022 · 1 comment · Fixed by #76607
Labels
A-sql-semantics C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. E-easy Easy issue to tackle, requires little or no CockroachDB experience good first issue S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@knz
Copy link
Contributor

knz commented Jan 2, 2022

Describe the problem

Followup to #74373 and #70033

I was running some tests and was mistakenly typing SET trace.debug.enable = on
instead of SET CLUSTER SETTING ...

and the statement was succeeding (#70033) but I wasn't getting the result I wanted.

I feel it is defective UX that I did not get any feedback about the fact I wasn't using the right statement.
Prior to #70033, such a mistake was clear.

Expected behavior

I would like SET to report a warning/notice when the name given is also a valid cluster setting.
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-sql-semantics S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption. labels Jan 2, 2022
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Jan 2, 2022
@knz
Copy link
Contributor Author

knz commented Jan 2, 2022

cc @otan @rafiss for triage

@rafiss rafiss added E-easy Easy issue to tackle, requires little or no CockroachDB experience good first issue labels Jan 10, 2022
@rafiss rafiss mentioned this issue Feb 15, 2022
Merged
@craig craig bot closed this as completed in 1a8570f Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sql-semantics C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. E-easy Easy issue to tackle, requires little or no CockroachDB experience good first issue S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: add notice for custom var with the same name as a cluster setting rafiss/cockroach
2 participants
@knz @rafiss