kv/kvserver: TestStoreSplitRangeLookupRace failed #75198
Assignees
Labels
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
Comments
cockroach-teamcity
added
branch-master
|
kv/kvserver.TestStoreSplitRangeLookupRace failed with artifacts on master @ 506412ffdb6d0f6d4952d2599b81cb9294a123a1: Fatal error: Stack: Log preceding fatal error
Help
See also: How To Investigate a Go Test Failure (internal)
|
|
The test hasn't changed, are we now using reverse lookups in more places? cc @nvanbenschoten |
|
Repros pretty readily, could just bisect: |
|
Don't even have to bisect, 365b4da is the gift that keeps on giving. |
|
kv/kvserver.TestStoreSplitRangeLookupRace failed with artifacts on master @ 58ceac139a7e83052171121b28026a7366f16f7e: Fatal error: Stack: Log preceding fatal error
Help
See also: How To Investigate a Go Test Failure (internal)
|
|
Looking. |
|
Is this just a faulty assertion? The testing helper we're using makes allowances for both kinds of requests: cockroach/pkg/kv/range_lookup.go Lines 452 to 458 in 9b449c5 Curious why we're seeing roachpb.ReverseScanRequests now, and not before. |
Because of this perhaps? 619f395#diff-c06addbc3a4c309a2e688a1a66fb995ad5e8d598ad77cf9e0ff5835f43b0ce93R561-R576 Edit: No, just tried reverting it and still hitting the same. |
|
Looks like it's coming from here: cockroach/pkg/kv/range_lookup.go Lines 375 to 377 in 9b449c5 Adding a bit of logging and it appears to be because of new query executions we're now doing: cockroach/pkg/spanconfig/spanconfigkvaccessor/kvaccessor.go Lines 204 to 206 in 5f28900 I'm not sure we're doing anything out of the ordinary, just the test needs to be relaxed in expecting both kinds of request types. Sending a PR. |
craig bot
pushed a commit
that referenced
this issue
Jan 21, 2022
75261: row: fetcher cleanup and improvements r=RaduBerinde a=RaduBerinde #### rowenc: remove deprecated return from DecodeIndexKey Release note: None #### row: minor cleanup around foundNull This moves around some code to make it clear that it's only relevant in a specific case. Release note: None #### row: clean up ReadIndexKey Renaming to DecodeIndexKey and removing return value which is no longer useful. Release note: None #### row: more Fetcher cleanup - improve comment for `indexKey`; - unexport NextKey; - slightly change the return value of nextKey to simplify the logic (the semantic difference is what the first call returns, which is not used); - use numKeysPerRow instead of counting the total families; this enables the faster paths for more cases. Release note: None 75272: kvserver: de-flake TestStoreSplitRangeLookupRace r=irfansharif a=irfansharif Fixes #75198. This test was a bit brittle in expecting only one kind of range lookup request in a testing filter -- it was always possible to intercept a ReverseScanRequest, and after enabling span configs (#73876), we now have an internal query ("validate-span-cfgs") that makes use of it. See #75198 for more details. Release note: None 75281: sql: disable span-config on flakey 5node tests r=cucaroach a=cucaroach Temporary fix for #72802 and 5node/distsql_enum CI failures. Due to #73876 these tests have become flakey. With the disable-span-configs option 70 runs of make stress on the opt logic tests pass. Release note: None Co-authored-by: Radu Berinde <radu@cockroachlabs.com> Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com> Co-authored-by: Tommy Reilly <treilly@cockroachlabs.com>
gtr
pushed a commit
to gtr/cockroach
that referenced
this issue
Jan 24, 2022
Fixes cockroachdb#75198. This test was a bit brittle in expecting only one kind of range lookup request in a testing filter -- it was always possible to intercept a ReverseScanRequest, and after enabling span configs (cockroachdb#73876), we now have an internal query ("validate-span-cfgs") that makes use of it. See cockroachdb#75198 for more details. Release note: None
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kv/kvserver.TestStoreSplitRangeLookupRace failed with artifacts on master @ 506412ffdb6d0f6d4952d2599b81cb9294a123a1:
Fatal error:
Stack:
Log preceding fatal error
Help
See also: How To Investigate a Go Test Failure (internal)
Parameters in this failure:
TAGS=deadlock
GOFLAGS=-parallel=2
This test on roachdash | Improve this report!
The text was updated successfully, but these errors were encountered: