Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CHACHA ciphers for TLS 1.2 #80483

Closed
chriscasano opened this issue Apr 25, 2022 · 2 comments · Fixed by #80476
Closed

Add CHACHA ciphers for TLS 1.2 #80483

chriscasano opened this issue Apr 25, 2022 · 2 comments · Fixed by #80476
Labels
A-security C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-community Originated from the community

Comments

@chriscasano
Copy link

chriscasano commented Apr 25, 2022

Please add support for the following ciphers in TLS 1.2

  • TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256
  • TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256

Jira issue: CRDB-15593

@chriscasano chriscasano added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Apr 25, 2022
@blathers-crl
Copy link

blathers-crl bot commented Apr 25, 2022

Hello, I am Blathers. I am here to help you get the issue triaged.

It looks like you have not filled out the issue in the format of any of our templates. To best assist you, we advise you to use one of these templates.

I was unable to automatically find someone to ping.

If we have not gotten back to your issue within a few business days, you can try the following:

  • Join our community slack channel and ask on #cockroachdb.
  • Try find someone from here if you know they worked closely on the area and CC them.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner labels Apr 25, 2022
@rimadeodhar rimadeodhar added A-security and removed X-blathers-untriaged blathers was unable to find an owner labels Apr 25, 2022
@bdarnell
Copy link
Contributor

Note that these ciphers are already supported, but they're listed in our source code under the non-standard aliases TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305 and TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305. We should switch to the standard names to avoid confusion, but there is no functional change (and no need for a new release/upgrade to support these ciphers)

@craig craig bot closed this as completed in d912b66 May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-security C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-community Originated from the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants