Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admission: noisy granter CPULoad logs #81360

Closed
tbg opened this issue May 17, 2022 · 2 comments
Closed

admission: noisy granter CPULoad logs #81360

tbg opened this issue May 17, 2022 · 2 comments
Assignees
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. E-starter Might be suitable for a starter project for new employees or team members. T-kv KV Team

Comments

@tbg
Copy link
Member

tbg commented May 17, 2022

I've seen this in many different experiments:

image

We should remove/downgrade this log message and add a metric instead.

Jira issue: CRDB-15222

@tbg tbg added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label May 17, 2022
@blathers-crl blathers-crl bot added the T-kv KV Team label May 17, 2022
@jlinder jlinder added sync-me and removed sync-me labels May 20, 2022
@tbg tbg added the E-starter Might be suitable for a starter project for new employees or team members. label May 31, 2022
@tbg tbg added T-kv-replication and removed T-kv KV Team labels May 31, 2022
@sumeerbhola
Copy link
Collaborator

(from an internal conversation)
There are 2 reasons for these log statements:

  • to know if this switching is happening and how often, in case we need to improve the heuristic in runnable.go.
  • if we see some weird admission control behavior, we want to be able to tell whether there was any use of the 250ms sampling during that time interval.

Both use cases can be addressed using two cumulative metrics (or preferably one metric with a label) that count the number of 250ms samples and the number of 1ms samples.

@irfansharif
Copy link
Contributor

3cfc79f + #96511.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. E-starter Might be suitable for a starter project for new employees or team members. T-kv KV Team
Projects
None yet
Development

No branches or pull requests

4 participants