Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keys,*: eliminate the concept of a SystemConfigSpan #82178

Closed
ajwerner opened this issue May 31, 2022 · 0 comments · Fixed by #82281
Closed

keys,*: eliminate the concept of a SystemConfigSpan #82178

ajwerner opened this issue May 31, 2022 · 0 comments · Fixed by #82281
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@ajwerner
Copy link
Contributor

ajwerner commented May 31, 2022

Is your feature request related to a problem? Please describe.
Now that #70560 is over and shipped, we can make the system config span a normal key span and rid our codebase of the concept.

Describe the solution you'd like
I'd start by deleting the symbols and seeing what happens. We'll want to change the span config logic which currently deals with it.

Additional context

This is in the way of #81457 because that change wants to add a secondary index to system.users and the index code wants to split off the index. We could definitely just work around that, but it feels good to have a push.

Jira issue: CRDB-16240

@ajwerner ajwerner added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label May 31, 2022
@craig craig bot closed this as completed in 0050edb Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
1 participant