Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: lookup user info using stable ids #87080

Open
RichardJCai opened this issue Aug 29, 2022 · 0 comments
Open

sql: lookup user info using stable ids #87080

RichardJCai opened this issue Aug 29, 2022 · 0 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@RichardJCai
Copy link
Contributor

RichardJCai commented Aug 29, 2022 •
edited by exalate-issue-sync bot
Loading

Now that we've added ids to users in #81457

Once the remaining migrations are completed #87079
We can update all current lookups that depend on usernames (ie CheckPrivilegeForUser) to use IDs instead.
To do this, we'll need to lookup every usage of SQLUsername and audit if it should use id for lookup.

This PR can be worked on but will likely be hard to rebase.
#79965

Epic CRDB-25679
Jira issue: CRDB-19141
@RichardJCai RichardJCai added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RichardJCai