Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlitelogictest: 2-hour time limit isn't sufficient #89807

Closed
cockroach-teamcity opened this issue Oct 12, 2022 · 3 comments
Closed

sqlitelogictest: 2-hour time limit isn't sufficient #89807

cockroach-teamcity opened this issue Oct 12, 2022 · 3 comments
Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Oct 12, 2022

pkg/sql/sqlitelogictest/tests/local/local_test.TestSqlLiteLogic_testindexview1000slt_good_0_test failed with artifacts on release-22.2.0 @ 58ba620ed525d6e5cf6f509c8a6b9fef75e0f35e:

Slow failing tests:
TestSqlLiteLogic_testindexview1000slt_good_0_test - 11.84s

Slow passing tests:
TestSqlLiteLogic_testindexorderby1000slt_good_0_test - 4568.41s
TestSqlLiteLogic_testindexorderby_nosort1000slt_good_0_test - 1878.13s
TestSqlLiteLogic_testindexdelete100slt_good_2_test - 226.56s
TestSqlLiteLogic_testindexin1000slt_good_0_test - 171.59s
TestSqlLiteLogic_testindexbetween100slt_good_3_test - 115.01s
TestSqlLiteLogic_testindexcommute10slt_good_20_test - 48.15s
TestSqlLiteLogic_testindexcommute100slt_good_7_test - 43.77s
TestSqlLiteLogic_testindexorderby10slt_good_21_test - 43.28s
TestSqlLiteLogic_testindexcommute10slt_good_4_test - 42.49s
TestSqlLiteLogic_testindexorderby_nosort10slt_good_22_test - 23.37s
TestSqlLiteLogic_testindexorderby_nosort10slt_good_37_test - 22.40s
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-20448

@cockroach-teamcity cockroach-teamcity added branch-release-22.2.0 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Oct 12, 2022
@cockroach-teamcity cockroach-teamcity added this to the 22.2 milestone Oct 12, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Oct 12, 2022
@DrewKimball
Copy link
Collaborator

Looks like we can still time out on the 2-hour time limit.

No pass/skip/fail event found for test
=== RUN   TestSqlLiteLogic_testindexview1000slt_good_0_test
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/a73952b60ff0ae2ffcb12ae85ca66813/logTestSqlLiteLogic_testindexview1000slt_good_0_test1969041055
    test_log_scope.go:79: use -show-logs to present logs inline
[09:18:05] setting distsql_workmem='48549B';
[09:18:05] rng seed: 2643940298289358370
[09:18:07] --- progress: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/3669/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/sql/sqlitelogictest/tests/local/local_test_/local_test.runfiles/com_github_cockroachdb_cockroach/external/com_github_cockroachdb_sqllogictest/test/index/view/1000/slt_good_0.test: 1012 statements
[09:18:09] --- progress: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/3669/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/sql/sqlitelogictest/tests/local/local_test_/local_test.runfiles/com_github_cockroachdb_cockroach/external/com_github_cockroachdb_sqllogictest/test/index/view/1000/slt_good_0.test: 1137 statements
[09:18:11] --- progress: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/3669/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/sql/sqlitelogictest/tests/local/local_test_/local_test.runfiles/com_github_cockroachdb_cockroach/external/com_github_cockroachdb_sqllogictest/test/index/view/1000/slt_good_0.test: 1339 statements
[09:18:13] --- progress: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/3669/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/sql/sqlitelogictest/tests/local/local_test_/local_test.runfiles/com_github_cockroachdb_cockroach/external/com_github_cockroachdb_sqllogictest/test/index/view/1000/slt_good_0.test: 1496 statements
[09:18:15] --- progress: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/3669/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/sql/sqlitelogictest/tests/local/local_test_/local_test.runfiles/com_github_cockroachdb_cockroach/external/com_github_cockroachdb_sqllogictest/test/index/view/1000/slt_good_0.test: 1543 statements
panic: test timed out after 1h59m55s

@michae2
Copy link
Collaborator

michae2 commented Oct 25, 2022

We think this is better now.

@michae2 michae2 closed this as completed Oct 25, 2022
@yuzefovich
Copy link
Member

My guess is that bumping the lower bound of workmem size is what did the trick.

@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team
Projects
Archived in project
Development

No branches or pull requests

4 participants