Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel CI not finding test failures related #92592

Closed
rickystewart opened this issue Nov 28, 2022 · 0 comments · Fixed by #92593
Closed

Bazel CI not finding test failures related #92592

rickystewart opened this issue Nov 28, 2022 · 0 comments · Fixed by #92593
Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf

Comments

@rickystewart
Copy link
Collaborator

rickystewart commented Nov 28, 2022 •
edited by exalate-issue-sync bot
Loading

From #84608:

GitHub CI Run
Bazel CI Run

GitHub CI reports the following legitimate failures which Bazel CI does not see:

=== RUN   TestLint/TestStaticCheck
    lint_test.go:1751:
        pkg/sql/logictest/logic.go:1219:6: func getFreePort is unused (U1000)
    lint_test.go:1751:
        pkg/sql/logictest/logic.go:1240:21: func (*logicTest).newTestServerCluster is unused (U1000)
    lint_test.go:1751:
        pkg/sql/logictest/logic.go:1817:3: this value of bootstrapBinaryPath is never used (SA4006)
    --- FAIL: TestLint/TestStaticCheck (959.91s)

Epic CRDB-15060
@rickystewart rickystewart added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-build-system T-dev-inf labels Nov 28, 2022
@rickystewart rickystewart changed the title Bazel CI not finding test failures related Bazel CI not finding "lint" failures related to unused values Nov 28, 2022
@exalate-issue-sync exalate-issue-sync bot changed the title Bazel CI not finding "lint" failures related to unused values Bazel CI not finding test failures related Nov 28, 2022
@knz knz mentioned this issue Nov 28, 2022
Merged
@craig craig bot closed this as completed in 1bc257b Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

logictest: avoid a lint failure knz/cockroach
1 participant
@rickystewart