Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql, kv: propagate and utilize estimated row count hint for KV projection pushdown work #94850

Open
yuzefovich opened this issue Jan 6, 2023 · 0 comments
Open

sql, kv: propagate and utilize estimated row count hint for KV projection pushdown work #94850

yuzefovich opened this issue Jan 6, 2023 · 0 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team

Comments

@yuzefovich
Copy link
Member

yuzefovich commented Jan 6, 2023 •
edited by cockroach-jira-scripts
Loading

In some cases, we have the estimated row count hint for how many rows will be needed from the table reader. In the initial version of the KV projection pushdown work that information is not utilized, but it'd be nice to take advantage of the hint. In particular, this will allow the wrapped cFetcher to create batches of reasonable capacity (rather than doing exponential increase starting with the size of 1).

Note that this estimate is already used to set MaxSpanRequestKeys limit on the whole BatchRequest on the SQL side.

Jira issue: CRDB-23186
@yuzefovich yuzefovich added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jan 6, 2023
@yuzefovich yuzefovich self-assigned this Jan 6, 2023
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Jan 6, 2023
@yuzefovich yuzefovich mentioned this issue Jan 6, 2023
Open
10 tasks
@yuzefovich yuzefovich removed their assignment Mar 14, 2023
@mgartner mgartner moved this to New Backlog in SQL Queries Jul 24, 2023
@yuzefovich yuzefovich mentioned this issue Nov 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team
Projects
SQL Queries
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuzefovich