Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: TestReplicaProbeRequest flaked on master #97136

Closed
msbutler opened this issue Feb 14, 2023 · 2 comments · Fixed by #98747
Closed

kvserver: TestReplicaProbeRequest flaked on master #97136

msbutler opened this issue Feb 14, 2023 · 2 comments · Fixed by #98747
Assignees
@tbg
Labels
C-test-failure Broken test (automatically or manually discovered).

Comments

@msbutler
Copy link
Collaborator

msbutler commented Feb 14, 2023 •
edited by cockroach-jira-scripts
Loading

See flake here.

Jira issue: CRDB-24537
@msbutler msbutler added C-test-failure Broken test (automatically or manually discovered). T-kv-replication labels Feb 14, 2023
@blathers-crl
Copy link

blathers-crl bot commented Feb 14, 2023

cc @cockroachdb/replication

@tbg
Copy link
Member

tbg commented Feb 21, 2023 

Failed
=== RUN   TestReplicaProbeRequest
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/33e1d369c27b9c01b2b6009c561815a3/logTestReplicaProbeRequest723466813
    test_log_scope.go:79: use -show-logs to present logs inline
    replica_probe_test.go:137: ignoring: result is ambiguous: unable to determine whether command was applied via snapshot
    replica_probe_test.go:150: condition failed to evaluate within 45s: waiting for stores to apply command: 3/2
    panic.go:522: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/33e1d369c27b9c01b2b6009c561815a3/logTestReplicaProbeRequest723466813
--- FAIL: TestReplicaProbeRequest (47.62s)

@tbg tbg mentioned this issue Mar 16, 2023
Merged
craig bot pushed a commit that referenced this issue Mar 16, 2023
@knz @pav-kv @tbg
Merge #98574 #98721 #98747
7109264 
98574: sql: support tenant configuration templates r=stevendanna,ecwall a=knz

Fixes #98573.
Epic: CRDB-23559
First commit from #98726.

This change introduces the LIKE clause to CREATE TENANT, which makes CREATE TENANT copy the parameters (but not the storage keyspace) from the tenant selected by LIKE.

Also if LIKE is not specified, but the (new) cluster setting `sql.create_tenant.default_template` is not empty, the value of the cluster setting is used implicitly as LIKE clause.

A proposed use of this is cluster-to-cluster replication, considering
cutover as well. On the target (sink) cluster, the operator would do:

```
CREATE TENANT application LIKE app_template
  FROM REPLICATION OF application ON ....
```

And then cutover would look something like the following if they
wanted the tenant to still be named "application"

```
ALTER TENANT application CUTOVER TO LATEST;
DROP TENANT application; -- if there's one already
ALTER TENANT application START SERVICE SHARED;
```

Release note: None

98721: go.mod: bump etcd-io/raft to 5fe1c31 r=tbg a=pavelkalinnikov

Fixes #97926
Epic: none
Release note (bug fix): fixed a rare panic in upstream etcd-io/raft when message appends race with log compaction

98747: kvserver: deflake TestReplicaProbeRequest r=pavelkalinnikov a=tbg

When we ignored an ambigous result but the probe didn't actually happen,
a later condition in the test would fail.

Retry the probe on ambiguous results instead; the test already only
expects the probe to happen "at least once", so we don't introduce
any new issues should a successful probe end up being retried.

Fixes #97136.

Epic: none
Release note: None


Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Co-authored-by: Pavel Kalinnikov <pavel@cockroachlabs.com>
Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
@craig craig bot closed this as completed in 989e615 Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbg tbg

Labels
C-test-failure Broken test (automatically or manually discovered).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvserver: deflake TestReplicaProbeRequest tbg/cockroach
2 participants
@tbg @msbutler