Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: add CriticalNodes rpc #97418

Closed
zachlite opened this issue Feb 21, 2023 · 0 comments
Closed

server: add CriticalNodes rpc #97418

zachlite opened this issue Feb 21, 2023 · 0 comments
Assignees
@zachlite
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@zachlite
Copy link
Contributor

zachlite commented Feb 21, 2023 •
edited by exalate-issue-sync bot
Loading

Is your feature request related to a problem? Please describe.
There should be a way to query the system tenant for nodes that are critical. A critical node is a node whose unexpected termination / removal from the cluster could cause data loss.

Describe the solution you'd like
The RPC should make use of the SpanConfigConformanceReport work done in #90016. The conformance report returns replica and node information for each non-conformance range, so we can use this information to accumulate a list of potentially critical node IDs.

Epic: https://cockroachlabs.atlassian.net/browse/CRDB-10630

Jira issue: CRDB-24687

Epic CRDB-10630
@zachlite zachlite added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv-observability labels Feb 21, 2023
@zachlite zachlite self-assigned this Feb 21, 2023
@zachlite zachlite mentioned this issue Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zachlite zachlite

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zachlite