Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non root user as default for tests #97535

Closed
rimadeodhar opened this issue Feb 22, 2023 · 2 comments
Closed

Use non root user as default for tests #97535

rimadeodhar opened this issue Feb 22, 2023 · 2 comments
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-postmortem Originated from a Postmortem action item. quality-friday A good issue to work on on Quality Friday T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@rimadeodhar
Copy link
Collaborator

rimadeodhar commented Feb 22, 2023

Currently, we end up defaulting to using root user while running logictests and the default test cluster settings. We should switch to using non root user to allow for testing codepaths that are enforced for non root users (for e.g. system.privileges checks etc.).

This request comes from discussion during this postmortem.

Tests to consider:

  • logic tests
  • unit tests that use the in-memory TestServer
  • roachtests

Jira issue: CRDB-24743

@rimadeodhar rimadeodhar added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-postmortem Originated from a Postmortem action item. labels Feb 22, 2023
@rafiss rafiss added the A-testing Testing tools and infrastructure label Feb 23, 2023
@blathers-crl blathers-crl bot added the T-testeng TestEng Team label Feb 23, 2023
@blathers-crl
Copy link

blathers-crl bot commented Feb 23, 2023

cc @cockroachdb/test-eng

@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Feb 23, 2023
@exalate-issue-sync exalate-issue-sync bot removed the T-testeng TestEng Team label Mar 6, 2023
@exalate-issue-sync exalate-issue-sync bot assigned rafiss and unassigned e-mbrown May 29, 2023
@erikgrinaker erikgrinaker added the quality-friday A good issue to work on on Quality Friday label Jul 20, 2023
@rafiss
Copy link
Collaborator

rafiss commented Jan 9, 2024

Closing since we aren't able to prioritize this large change. Instead we'll rely on #63145 being completed for roactests, and when we write other new tests, we'll decide to use non-root users on a case-by-case basis.

@rafiss rafiss closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-postmortem Originated from a Postmortem action item. quality-friday A good issue to work on on Quality Friday T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants