Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: fix stmtTraceThreshold for pausable portals #99404

Open
ZhouXing19 opened this issue Mar 23, 2023 · 0 comments
Open

sql: fix stmtTraceThreshold for pausable portals #99404

ZhouXing19 opened this issue Mar 23, 2023 · 0 comments
Labels
A-pausable-portals Issues related to multiple active portals C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@ZhouXing19
Copy link
Collaborator

ZhouXing19 commented Mar 23, 2023 •
edited by exalate-issue-sync bot
Loading

Since a pausable portal can be re-executed by re-calling connExecutor.ExecStmtInOpenState(), we should better record the trace threshold for all executions.

cockroach/pkg/sql/conn_executor_exec.go

Line 726 in d8ea15c

stmtTraceThreshold := TraceStmtThreshold.Get(&ex.planner.execCfg.Settings.SV)

Specifically, now each re-execution will get a fresh budget and we won't include details about the previous executions, only about the last one.

Jira issue: CRDB-25867

Epic CRDB-25183
@ZhouXing19 ZhouXing19 added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-pausable-portals Issues related to multiple active portals T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-pausable-portals Issues related to multiple active portals C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ZhouXing19