Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catalog: rename descriptors collection ByID to ByIDWithoutLease #99506

Closed
fqazi opened this issue Mar 24, 2023 · 0 comments · Fixed by #128932
Closed

catalog: rename descriptors collection ByID to ByIDWithoutLease #99506

fqazi opened this issue Mar 24, 2023 · 0 comments · Fixed by #128932
Assignees
@rafiss
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@fqazi
Copy link
Collaborator

fqazi commented Mar 24, 2023 •
edited by cockroach-jira-scripts
Loading

The ByID interfaces on the descriptors collection can be deceptive since it only acquires descriptors without a lease. So, it's possible to misinteperate the meaning and think you're getting a leased descriptor. We should rename ByID to ByIDWithoutLease to be explicit, since this is a critical detail

Jira issue: CRDB-25908
@fqazi fqazi added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Mar 24, 2023
@fqazi fqazi self-assigned this Mar 24, 2023
@rafiss rafiss added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Aug 12, 2024
@rafiss rafiss assigned rafiss and unassigned fqazi Aug 13, 2024
@rafiss rafiss mentioned this issue Aug 13, 2024
Merged
@craig craig bot closed this as completed in b6c7012 Aug 14, 2024
@rafiss rafiss added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. and removed C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafiss rafiss

Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
SQL Foundations
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

catalog: rename ByID to ByIDWithoutLeased rafiss/cockroach
2 participants
@rafiss @fqazi