Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: roachtest: use local SSDs for disk-stall failover tests #100020

Merged
merged 1 commit into from
Mar 30, 2023
Merged

release-23.1: roachtest: use local SSDs for disk-stall failover tests #100020

merged 1 commit into from
Mar 30, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 30, 2023 •
edited by nicktrav
Loading

Backport 1/1 commits from #99963 on behalf of @nicktrav.

/cc @cockroachdb/release

The disk-stalled roachtests were updated in #99747 to use local SSDs. This change broke the failover/*/disk-stall tests, which look for /dev/sdb on GCE (the used for GCE Persistent Disks), but the tests still create clusters with local SSDs (the roachtest default).

Fix #99927.
Fix #99925.
Fix #99901.

Touches #97968.

Release note: None.

Release justification: Test only.

@nicktrav
roachtest: use local SSDs for disk-stall failover tests
24d115e 
The disk-stalled roachtests were updated in #99747 to use PDs in favor
of local SSDs. This change broke the `failover/*/disk-stall` tests,
which look for `/dev/sdb` on GCE (the device name used for GCE
Persistent Disks), but the tests still create clusters with local SSDs
(the roachtest default).

Fix #99902.
Fix #99926.
Fix #99930.

Touches #97968.

Release note: None.
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 30, 2023 05:35
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99963 branch from aec78f3 to 5417ba6 Compare March 30, 2023 05:35
@blathers-crl blathers-crl bot requested review from herkolategan and srosenberg and removed request for a team March 30, 2023 05:35
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99963 branch from 42d159c to 24d115e Compare March 30, 2023 05:35
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 30, 2023 •
edited by nicktrav
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 30, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

sumeerbhola
sumeerbhola approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @andrewbaptist, @herkolategan, @nicktrav, @smg260, and @srosenberg)

jbowens
jbowens approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on @andrewbaptist, @herkolategan, @nicktrav, @smg260, and @srosenberg)

@nicktrav
Copy link
Collaborator

TFTRs!

@nicktrav nicktrav merged commit e3a594b into release-23.1 Mar 30, 2023
@nicktrav nicktrav deleted the blathers/backport-release-23.1-99963 branch March 30, 2023 17:35
This was referenced Mar 30, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbowens jbowens jbowens approved these changes

@sumeerbhola sumeerbhola sumeerbhola approved these changes

@herkolategan herkolategan Awaiting requested review from herkolategan herkolategan is a code owner automatically assigned from cockroachdb/test-eng

@srosenberg srosenberg Awaiting requested review from srosenberg srosenberg is a code owner automatically assigned from cockroachdb/test-eng

@andrewbaptist andrewbaptist Awaiting requested review from andrewbaptist

@nicktrav nicktrav Awaiting requested review from nicktrav

@smg260 smg260 Awaiting requested review from smg260

Assignees

@nicktrav nicktrav

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cockroach-teamcity @nicktrav @jbowens @sumeerbhola