Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: sqlsmith: add DELETE FROM ... USING and UPDATE ... FROM support #100542

Merged
merged 1 commit into from
Apr 4, 2023
Merged

release-23.1: sqlsmith: add DELETE FROM ... USING and UPDATE ... FROM support #100542

merged 1 commit into from
Apr 4, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 4, 2023 •
edited by yuzefovich
Loading

Backport 1/1 commits from #98914 on behalf of @yuzefovich.

/cc @cockroachdb/release

This commit makes it so that the sqlsmith can now generate statements of the form DELETE FROM ... USING and UPDATE ... FROM. We toss a coin every time before deciding to add another table (meaning in 50% cases these forms are not used, in 25% we have 1 extra table, etc). It also adjusts the generation of the RETURNING clause for DELETE and UPDATE to be able to pick from any of the table sources.

Fixes: #98910.

Release note: None

Release justification: test-only change.

@yuzefovich
sqlsmith: add DELETE FROM ... USING and UPDATE ... FROM support
e640610 
This commit makes it so that the sqlsmith can now generate statements
of the form `DELETE FROM ... USING` and `UPDATE ... FROM`. We toss
a coin every time before deciding to add another table (meaning in 50%
cases these forms are not used, in 25% we have 1 extra table, etc). It
also adjusts the generation of the RETURNING clause for DELETE and
UPDATE to be able to pick from any of the table sources.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner April 4, 2023 01:09
@blathers-crl blathers-crl bot requested a review from DrewKimball April 4, 2023 01:10
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-98914 branch from 13d9fe7 to 02b02ea Compare April 4, 2023 01:10
@blathers-crl blathers-crl bot requested a review from mgartner April 4, 2023 01:10
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-98914 branch from 587c363 to e640610 Compare April 4, 2023 01:10
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 4, 2023 •
edited by yuzefovich
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 4, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

mgartner
mgartner approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuzefovich yuzefovich merged commit 954bcf4 into release-23.1 Apr 4, 2023
@yuzefovich yuzefovich deleted the blathers/backport-release-23.1-98914 branch April 4, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgartner mgartner mgartner approved these changes

@DrewKimball DrewKimball Awaiting requested review from DrewKimball DrewKimball was automatically assigned from cockroachdb/sql-queries

@michae2 michae2 Awaiting requested review from michae2

@yuzefovich yuzefovich Awaiting requested review from yuzefovich

Assignees

@yuzefovich yuzefovich

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @mgartner @yuzefovich