changefeedccl: Break gossip dependency #101096
Conversation
Break the dependency on Gossip library which was used to determine the number of nodes in the cluster in order to limit scanner concurrency. Instead, rely on the range descriptors in order to determine how many nodes host the ranges that need to be scanned. Fixes cockroachdb#47971 Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @miretskiy and @shralex)
pkg/ccl/changefeedccl/kvfeed/scanner.go line 254 at r1 (raw file):
// getRangesToProcess returns the list of ranges covering input list of spans. // Returns the number of nodes that are leaseholders for those spans.
nit: This is not necessarily the number of leaseholders, right? it.Desc().InternalReplicas returns all the nodes hosting replicas.
Do you feel strongly on this (and force rerunning CI)? |
There was a problem hiding this comment.
I do not feel strongly. Feel free to merge.
Reviewable status:
|
bors r+ |
|
Build succeeded: |
Break the dependency on Gossip library which was
used to determine the number of nodes in the cluster in order to limit scanner concurrency.
Instead, rely on the range descriptors in order
to determine how many nodes host the ranges that
need to be scanned.
Fixes #47971
Release note: None