-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachprod-microbench: improvements to reporting #102033
roachprod-microbench: improvements to reporting #102033
Conversation
64396c8
to
0cde9a8
Compare
56d62b6
to
f56f7c5
Compare
This change introduces a few small improvements to the reporting capabilities in roachprod-microbench. Missing microbenchmarks are now classified by timeouts, errors, or skipped status. These will be outputted to the log for inspection afterward. Also adds a quiet mode for reducing unnecessary output on CI builds.
f56f7c5
to
bed253e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @herkolategan and @smg260)
pkg/cmd/roachprod-microbench/benchmark.go
line 316 at r1 (raw file):
} tag := fmt.Sprintf("%d", logIndex) if response.ExitStatus == 124 {
The details are fuzzy to me -- where is this exit status coming from? I think it comes from run.sh
, but can't remember what that file is/where it's located.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @renatolabs and @smg260)
pkg/cmd/roachprod-microbench/benchmark.go
line 316 at r1 (raw file):
Previously, renatolabs (Renato Costa) wrote…
The details are fuzzy to me -- where is this exit status coming from? I think it comes from
run.sh
, but can't remember what that file is/where it's located.
Correct, although the remote command (runCommand
in benchmark.go
) that eventually gets executed is built up from a few parts including a possible timeout. It's the timeout
part of the command that will result in the 124 exit status here, given there was a timeout.
bors r=renatolabs |
Timed out. |
bors r=renatolabs |
Build succeeded: |
This change introduces a few small improvements to the reporting capabilities in roachprod-microbench. Missing microbenchmarks are now classified by timeouts, errors, or skipped status. These will be outputted to the log for inspection afterward.
Also adds a quiet mode for reducing unnecessary output on CI builds.