Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachprod-microbench: improvements to reporting #102033

Merged

Conversation

herkolategan
Copy link
Collaborator

@herkolategan herkolategan commented Apr 21, 2023

This change introduces a few small improvements to the reporting capabilities in roachprod-microbench. Missing microbenchmarks are now classified by timeouts, errors, or skipped status. These will be outputted to the log for inspection afterward.

Also adds a quiet mode for reducing unnecessary output on CI builds.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@herkolategan herkolategan force-pushed the hbl/roachprod-microbench-ignore-skips branch 2 times, most recently from 64396c8 to 0cde9a8 Compare April 26, 2023 17:18
@herkolategan herkolategan force-pushed the hbl/roachprod-microbench-ignore-skips branch 3 times, most recently from 56d62b6 to f56f7c5 Compare May 10, 2023 10:32
This change introduces a few small improvements to the reporting capabilities in
roachprod-microbench. Missing microbenchmarks are now classified by timeouts,
errors, or skipped status. These will be outputted to the log for inspection
afterward.

Also adds a quiet mode for reducing unnecessary output on CI builds.
@herkolategan herkolategan force-pushed the hbl/roachprod-microbench-ignore-skips branch from f56f7c5 to bed253e Compare May 10, 2023 12:22
@herkolategan herkolategan marked this pull request as ready for review May 10, 2023 13:08
@herkolategan herkolategan requested a review from a team as a code owner May 10, 2023 13:08
@herkolategan herkolategan requested review from smg260 and renatolabs and removed request for a team May 10, 2023 13:08
Copy link
Collaborator

@renatolabs renatolabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @herkolategan and @smg260)


pkg/cmd/roachprod-microbench/benchmark.go line 316 at r1 (raw file):

			}
			tag := fmt.Sprintf("%d", logIndex)
			if response.ExitStatus == 124 {

The details are fuzzy to me -- where is this exit status coming from? I think it comes from run.sh, but can't remember what that file is/where it's located.

Copy link
Collaborator Author

@herkolategan herkolategan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @renatolabs and @smg260)


pkg/cmd/roachprod-microbench/benchmark.go line 316 at r1 (raw file):

Previously, renatolabs (Renato Costa) wrote…

The details are fuzzy to me -- where is this exit status coming from? I think it comes from run.sh, but can't remember what that file is/where it's located.

Correct, although the remote command (runCommand in benchmark.go) that eventually gets executed is built up from a few parts including a possible timeout. It's the timeout part of the command that will result in the 124 exit status here, given there was a timeout.

@herkolategan
Copy link
Collaborator Author

bors r=renatolabs

@craig
Copy link
Contributor

craig bot commented May 11, 2023

Timed out.

@herkolategan
Copy link
Collaborator Author

herkolategan commented May 12, 2023

bors r=renatolabs

@craig
Copy link
Contributor

craig bot commented May 12, 2023

Build succeeded:

@craig craig bot merged commit 81a3824 into cockroachdb:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants