roachprod: fix regression in propagateDiskLabels #103191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous PR [1] fixed data races, and as a result of refactoring, introduced another bug. When multiple zones are used, the `--zone` arg. is duplicated across all hosts. Epic: none Release note: None [1] cockroachdb#103087
srosenberg
requested review from
herkolategan,
smg260 and
renatolabs
and removed request for
a team
|
This change is |
srosenberg
added
backport-23.1.x
renatolabs
approved these changes
May 12, 2023
|
TFTR! Final attempt 🤞 bors r=renatolabs |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from e676243 to blathers/backport-release-22.2-103191: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR [1] fixed data races, and as a result of refactoring, introduced another bug.
When multiple zones are used, the
--zonearg. is duplicated across all hosts.Epic: none
Release note: None
[1] #103087