From b3b3ee065b3151bb93e60691c07988aeeb5d58ce Mon Sep 17 00:00:00 2001 From: Oleg Afanasyev Date: Fri, 14 Apr 2023 14:59:24 +0000 Subject: [PATCH] closedts: log err when incoming stream drops Currently we don't log error in the warning if incoming closedts stream is dropped by remote. Since those events are not frequent it would be beneficial to log actual error as we don't expect anything other than EOF which is handled separately. This PR adds error to the log message. Epic: none Release note: None --- pkg/kv/kvserver/closedts/sidetransport/receiver.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kv/kvserver/closedts/sidetransport/receiver.go b/pkg/kv/kvserver/closedts/sidetransport/receiver.go index 50f5c968af19..3a56c48cff5a 100644 --- a/pkg/kv/kvserver/closedts/sidetransport/receiver.go +++ b/pkg/kv/kvserver/closedts/sidetransport/receiver.go @@ -136,7 +136,7 @@ func (s *Receiver) onRecvErr(ctx context.Context, nodeID roachpb.NodeID, err err defer s.mu.Unlock() if err != io.EOF { - log.Warningf(ctx, "closed timestamps side-transport connection dropped from node: %d", nodeID) + log.Warningf(ctx, "closed timestamps side-transport connection dropped from node: %d (%s)", nodeID, err) } else { log.VEventf(ctx, 2, "closed timestamps side-transport connection dropped from node: %d (%s)", nodeID, err) }