release-23.1: roachtest: codify longer ttl external storage buckets #111086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
blathers-crl
bot
added
the
backport
|
This change is |
renatolabs
approved these changes
Sep 21, 2023
msbutler
force-pushed
the
butler-backport-ttl-bucket
branch
from
f9febc4
to
fc9c6b2
Compare
renatolabs
reviewed
Sep 22, 2023
pkg/testutils/backup.go
Outdated
| // bucket. In private test runs, the name of the bucket is passed through an | ||
| // environment variable. | ||
| func BackupTestingBucket() string { | ||
| return envutil.EnvOrDefaultString(backupTestingBucketEnvVar, defaultBackupBucket) |
There was a problem hiding this comment.
Probably better to have this code be exactly the same as master. Also EnvOrDefaultString is for internal (COCKROACH_*) vars only, I think this will panic.
There was a problem hiding this comment.
hrm. the linter was barking at me for not using envutil.... lemme figure out how to quiet the linter
msbutler
force-pushed
the
butler-backport-ttl-bucket
branch
from
fc9c6b2
to
bbd0653
Compare
Previously, the only codified external buckets for roachtests to back up to was the `cockroachdb-backup-testing` buckets in s3 and gcs which each had a ttl of 1 day. This low ttl is not suitable for roachtests that produce backups that the test failure investigator may want to inspect. This patch codifies the new `cockroachdb-backup-testing-long-ttl` buckets in s3 and gcs, which currently have a ttl of 20 days, the same ttl that team city artifacts have. This patch also points the c2c, backup-restore/mixed-version, and disagg-rebalance roachtests to use these new buckets. Note this PR only points roachtests that run in public TC environments to the new buckets. A future PR will set the BACKUP_TESTING_BUCKET_LONG_TTL env var for private roacttests to a new bucket with a longer ttl. Epic: none Release note: none
msbutler
force-pushed
the
butler-backport-ttl-bucket
branch
from
bbd0653
to
1537d25
Compare
renatolabs
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #110288
Previously, the only codified external buckets for roachtests to back up to was the
cockroachdb-backup-testingbuckets in s3 and gcs which each had a ttl of 1 day. This low ttl is not suitable for roachtests that produce backups that the test failure investigator may want to inspect. This patch codifies the newcockroachdb-backup-testing-long-ttlbuckets in s3 and gcs, which currently have a ttl of 20 days, the same ttl that team city artifacts have.This patch also points the c2c, backup-restore/mixed-version, and disagg-rebalance roachtests to use these new buckets.
Note this PR only points roachtests that run in public TC environments to the new buckets. A future PR will set the BACKUP_TESTING_BUCKET_LONG_TTL env var for private roacttests to a new bucket with a longer ttl.
Epic: none
Release note: none
Release justification: test only change