Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: remove unnecessary sideload inlining, add assertion #20573

Merged

Commits on Dec 11, 2017

  1. storage: remove unnecessary sideload inlining, add assertion

    `Replica.sendRaftMessages` used to contain logic to inline sideloaded entries
    for `MsgApps`. This was unnecessary, as `MsgApps` would never contain thin entries.
    This is because `replicaRaftStorage.Entries` already performs the sideload inlining
    for stable entries and `raft.unstable` always contain fat entries. Since these are
    the only two sources that `raft.sendAppend` gathers entries from to populate `MsgApps`,
    we should never see thin entries in `MsgApps`.
    
    This change replaces the inlining attempt with an assertion.
    
    Release note: None
    nvanbenschoten committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    cccf882 View commit details
    Browse the repository at this point in the history