changefeedccl: switch retryable errors back to a whitelist #36852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to blacklist" This reverts commit 200567d. Release note: None
For a while, the cdc/crdb-chaos and cdc/sink-chaos roachtests have been failing because an error that should be marked as retryable wasn't. As a result of the discussion in cockroachdb#35974, I tried switching from a whitelist (retryable error) to a blacklist (terminal error) in cockroachdb#36132, but on reflection this doesn't seem like a great idea. We added a safety net to prevent false negatives from retrying indefinitely but it was immediately apparent that this meant we needed to tune the retry loop parameters. Better is to just do the due diligence of investigating the errors that should be retried and retrying them. The commit is intended for backport into 19.1 once it's baked for a bit. Closes cockroachdb#35974 Closes cockroachdb#36018 Closes cockroachdb#36019 Closes cockroachdb#36432 Release note (bug fix): `CHANGEFEED` now retry instead of erroring in more situations
|
This change is |
nvanbenschoten
approved these changes
Apr 15, 2019
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1, 10 of 10 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @tbg)
|
Thanks for the review! Ran extended versions of these roachtests today and didn't see anything pop up of the original whitelisting issues. I did see crdb-choas sometimes take a surprising amount of time to recover, so filed #36879 to follow up. bors r=nvanbenschoten |
craig bot
pushed a commit
that referenced
this pull request
Apr 16, 2019
36804: sql/sem/pretty: use left alignment for column names in CREATE r=knz a=knz
Before:
```
CREATE TABLE t (
name STRING,
id INT8
NOT NULL
PRIMARY KEY
)
```
After:
```
CREATE TABLE t (
name STRING,
id INT8
NOT NULL
PRIMARY KEY
)
```
36852: changefeedccl: switch retryable errors back to a whitelist r=nvanbenschoten a=danhhz
For a while, the cdc/crdb-chaos and cdc/sink-chaos roachtests have been
failing because an error that should be marked as retryable wasn't. As a
result of the discussion in #35974, I tried switching from a whitelist
(retryable error) to a blacklist (terminal error) in #36132, but on
reflection this doesn't seem like a great idea. We added a safety net to
prevent false negatives from retrying indefinitely but it was
immediately apparent that this meant we needed to tune the retry loop
parameters. Better is to just do the due diligence of investigating the
errors that should be retried and retrying them.
The commit is intended for backport into 19.1 once it's baked for a bit.
Closes #35974
Closes #36018
Closes #36019
Closes #36432
Release note (bug fix): `CHANGEFEED` now retry instead of erroring in
more situations
36872: coldata: fix Slice when slicing up to batch.Length() r=yuzefovich a=asubiotto
A panic occured because we weren't treating the end slice index as
exclusive, resulting in an out of bounds panic when attempting to slice
the nulls slice.
Release note: None
Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com>
Co-authored-by: Alfonso Subiotto Marqués <alfonso@cockroachlabs.com>
Build succeeded |
This was referenced Apr 18, 2019
danhhz
added a commit
to danhhz/cockroach
that referenced
this pull request
Apr 22, 2019
They're known to be flaky until cockroachdb#36852 gets backported but that won't happen for another week. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while, the cdc/crdb-chaos and cdc/sink-chaos roachtests have been
failing because an error that should be marked as retryable wasn't. As a
result of the discussion in #35974, I tried switching from a whitelist
(retryable error) to a blacklist (terminal error) in #36132, but on
reflection this doesn't seem like a great idea. We added a safety net to
prevent false negatives from retrying indefinitely but it was
immediately apparent that this meant we needed to tune the retry loop
parameters. Better is to just do the due diligence of investigating the
errors that should be retried and retrying them.
The commit is intended for backport into 19.1 once it's baked for a bit.
Closes #35974
Closes #36018
Closes #36019
Closes #36432
Release note (bug fix):
CHANGEFEEDnow retry instead of erroring inmore situations