Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-19.1: changefeedccl: improve retryable error whitelisting #37092

Merged
merged 2 commits into from
May 6, 2019

Commits on Apr 24, 2019

  1. changefeedccl: switch retryable errors back to a whitelist

    For a while, the cdc/crdb-chaos and cdc/sink-chaos roachtests have been
    failing because an error that should be marked as retryable wasn't. As a
    result of the discussion in cockroachdb#35974, I tried switching from a whitelist
    (retryable error) to a blacklist (terminal error) in cockroachdb#36132, but on
    reflection this doesn't seem like a great idea. We added a safety net to
    prevent false negatives from retrying indefinitely but it was
    immediately apparent that this meant we needed to tune the retry loop
    parameters. Better is to just do the due diligence of investigating the
    errors that should be retried and retrying them.
    
    The commit is intended for backport into 19.1 once it's baked for a bit.
    
    Closes cockroachdb#35974
    Closes cockroachdb#36018
    Closes cockroachdb#36019
    Closes cockroachdb#36432
    
    Release note (bug fix): `CHANGEFEED` now retry instead of erroring in
    more situations
    danhhz committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    7f33dd7 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2019

  1. changefeedccl: log more details when returning with non-retryable errors

    The `%v` and `%+v` were switched from what I intended in the line that
    logs retryable errors and the one that handles non-retryable errors.
    
    Release note: None
    danhhz committed May 6, 2019
    Configuration menu
    Copy the full SHA
    3501024 View commit details
    Browse the repository at this point in the history