debug: don't error in check-store on Range without TruncatedState #40343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we get lots of errors like: ``` range 411: truncated index 0 should equal first index 0 - 1 range 306: truncated index 0 should equal first index 0 - 1 range 399: truncated index 0 should equal first index 0 - 1 range 290: truncated index 0 should equal first index 0 - 1 range 340: truncated index 0 should equal first index 0 - 1 range 547: truncated index 0 should equal first index 0 - 1 range 266: truncated index 0 should equal first index 0 - 1 ``` Release note: None
|
This change is |
tbg
approved these changes
Aug 29, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 29, 2019
40343: debug: don't error in check-store on Range without TruncatedState r=nvanbenschoten a=nvanbenschoten Otherwise we get lots of errors like: ``` range 411: truncated index 0 should equal first index 0 - 1 range 306: truncated index 0 should equal first index 0 - 1 range 399: truncated index 0 should equal first index 0 - 1 range 290: truncated index 0 should equal first index 0 - 1 range 340: truncated index 0 should equal first index 0 - 1 range 547: truncated index 0 should equal first index 0 - 1 range 266: truncated index 0 should equal first index 0 - 1 ``` Release note: None Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we get lots of errors like:
Release note: None